This repository was archived by the owner on Mar 7, 2025. It is now read-only.
DEPRECATION: add deprecation warning to this package #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the new formkit release, all old form element repositories are being deprecated.
Reviewer's Guide by SourceryThis pull request adds a deprecation warning to the auro-input component and updates the documentation build process to accommodate deprecated components. The README now displays a warning message, and the build process uses a custom script to generate the documentation. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Surge demo deployment failed! 😭 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a more specific deprecation date or timeline to the warning message.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| // setup | ||
| await templateFiller.extractNames(); | ||
|
|
||
| for (const fileConfig of fileConfigs(config)) { |
There was a problem hiding this comment.
suggestion: The fileConfigs function is called with an argument though it doesn't accept any.
Since fileConfigs is defined without parameters, passing config is unnecessary. Either update fileConfigs to accept configuration overrides or remove the argument to avoid confusion.
Suggested change
| for (const fileConfig of fileConfigs(config)) { | |
| for (const fileConfig of fileConfigs()) { |
Comment on lines
+62
to
+65
| .then(() => { | ||
| throw new Error("TESTING ERROR"); | ||
| Logger.log("Docs processed successfully"); | ||
| }) |
There was a problem hiding this comment.
suggestion (bug_risk): A testing error is thrown in the then block.
The throw statement will prevent the success log from ever being reached and might cause unexpected failures in production. Ensure this is intended or remove it once testing is complete.
Suggested change
| .then(() => { | |
| throw new Error("TESTING ERROR"); | |
| Logger.log("Docs processed successfully"); | |
| }) | |
| .then(() => { | |
| Logger.log("Docs processed successfully"); | |
| }) |
|
|
||
| This file is generated based on a template fetched from | ||
| `https://raw.githubusercontent.com/AlaskaAirlines/WC-Generator/master/componentDocs/README_updated_paths.md` | ||
| and copied to `./componentDocs/README.md` each time the the docs are compiled. |
There was a problem hiding this comment.
issue (typo): Typo: "the the"
There appears to be a typo in the phrase "the the docs are compiled".
Suggested change
| and copied to `./componentDocs/README.md` each time the the docs are compiled. | |
| and copied to `./componentDocs/README.md` each time the docs are compiled. |
Comment on lines
+63
to
+64
| throw new Error("TESTING ERROR"); | ||
| Logger.log("Docs processed successfully"); |
There was a problem hiding this comment.
suggestion (code-quality): Remove unreachable code. (remove-unreachable-code)
Suggested change
| throw new Error("TESTING ERROR"); | |
| Logger.log("Docs processed successfully"); | |
| throw new Error("TESTING ERROR"); | |
Explanation
Statements after areturn, break, continue or throw will never be executed.Leaving them in the code confuses the reader, who may believe that these
statements have some effect. They should therefore be removed.
DukeFerdinand
deleted the
deprecations/2025_03_05_add_deprecation_warnings
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves AlaskaAirlines/auro-formkit#394, adding deprecation warning to old form element repositories.
Summary by Sourcery
Adds a deprecation warning to the component and updates the documentation to reflect this change. The component is no longer supported and users are encouraged to migrate to Auro Formkit.
Documentation: