-
Notifications
You must be signed in to change notification settings - Fork 4
DEPRECATION: add deprecation warning to this package #241
Conversation
As part of the new formkit release, all old form element repositories are being deprecated.
Reviewer's Guide by SourceryThis pull request introduces a deprecation warning to the package by updating documentation and build scripts. It modifies the README to indicate deprecation, updates the stylesheet link, and changes the documentation build script to use a new processor. Additionally, it adds a new template for generating deprecated documentation and a script to process these templates. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a note in the README about the new location or repository for the Auro Formkit to guide users on where to find the updated component.
- Ensure that the deprecatedDocsProcessor.js script is thoroughly tested to handle all edge cases, as it is now responsible for generating the documentation.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
||
This file is generated based on a template fetched from | ||
`https://raw.githubusercontent.com/AlaskaAirlines/WC-Generator/master/componentDocs/README_updated_paths.md` | ||
and copied to `./componentDocs/README.md` each time the the docs are compiled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Repeated 'the' in sentence.
There's a repeated 'the' in the sentence 'each time the the docs are compiled.' It should be corrected to 'each time the docs are compiled.'
and copied to `./componentDocs/README.md` each time the the docs are compiled. | |
and copied to `./componentDocs/README.md` each time the docs are compiled. |
🎉 This PR is included in version 4.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-formkit#394, adding deprecation warning to old form element repositories.
Summary by Sourcery
Deprecate the current component by adding a warning in the README.md and updating the documentation generation process to reflect the deprecation status.
Enhancements:
Build:
Documentation: