ci(release): upgrade release-please-action to v5 - #160
Merged
Conversation
docvet and gepa-adk both cut releases today with fine-grained tokens on v5. This repo is the only one still on v4, whose bundled release-please 17.3.0 returns 403 on release creation with our fine-grained token even though the same token creates releases fine over the REST API.
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, targeted action-version bump with no other workflow logic modifications.
Pull request overview
This PR upgrades the repository’s Release Please GitHub Actions workflow to use googleapis/release-please-action@v5, aligning with sibling repositories and aiming to resolve the intermittent Resource not accessible by personal access token failure during release creation.
Changes:
- Bump
googleapis/release-please-actionfromv4tov5in the Release Please workflow.
File summaries
| File | Description |
|---|---|
| .github/workflows/release-please.yml | Updates Release Please action version to v5 to align with known-working configuration in sibling repos. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Please has failed on every attempt today with
Resource not accessible by personal access tokenon release creation, so v1.3.0 is still untagged and unpublished while the manifest reads 1.3.0.The token is not the cause. Using the
RELEASE_PLEASE_TOKENsecret inside this repo's own CI, the exact call release-please makes (non-draft release, full commit SHA onmain, body, prerelease flag, bothBearerandtokenauth schemes) returns 201 and creates a real tag, repeatedly. All test releases and tags were cleaned up. I also read release-please 17.3.0's source to confirm its payload matches what was tested.That leaves the action version as the only structural difference from the sibling repos:
googleapis/release-please-actionfrom v4 to v5, which ships release-please 17.6.0 instead of 17.3.0Test: CI only. After merge, trigger the workflow manually (
workflow_dispatch, added in #159) to cut v1.3.0.PR Review
Checklist
uv run pytest)uv run ruff check .)!in title andBREAKING CHANGE:in bodyReview Focus
Related