Skip to content

Conversation

gr8bit
Copy link

@gr8bit gr8bit commented Sep 3, 2023

This PR exposes the Page's public_on attribute via the api.

Now pages can be sorted using public_version_public_on field key with "sort" parameter
@tvdeyen
Copy link
Member

tvdeyen commented Mar 1, 2024

@gr8bit is this still something you want to work on or can we close this?

…ose_public_on

# Conflicts:
#	app/controllers/alchemy/json_api/pages_controller.rb
@tvdeyen
Copy link
Member

tvdeyen commented Nov 8, 2024

Hey @gr8bit I am still thinking this is a valuable addition, but reading the git commit history it seems you are struggling getting this stable. Is there anything I can help with?

@gr8bit
Copy link
Author

gr8bit commented Nov 8, 2024

Yes indeed, I had a hard time getting the ransackable_*-method overloading into a place where it reliably happens. That's why it's done in an additional place now - which I personally don't like at all, but it worked for now. If I remember correctly, the issue appears in development when classes are not eager loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants