Skip to content

Fix cookie validation error #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

VariableVixen
Copy link

Closes #259 by changing cookie validation to check all cookies, instead of only cookies from https://patreon.com/. This should be future-proof as well, in the event that Patreon further changes their cookies to use other domains.

This PR is intended to provide an easy, low-effort way to implement a fix for Patreon's recent breaking change, and will be closed should the issue be otherwise resolved.

Closes #259 by changing cookie validation to check all cookies, instead of only cookies from `https://patreon.com/`. This should be future-proof as well, in the event that Patreon further changes their cookies to use other domains.
@AlexCSDev
Copy link
Owner

The issue with this implementation is that it is pretty fragile. If, for some reason, something breaks in puppeteer and it starts returning cookies not limited to the current page it will be pretty hard to figure out what goes wrong since __cf_bm cookie name is shared across all sites protected by cloudflare bot management platform and session_id cookie name is generic enough to be used by other sites.

I think those kind of changes on patreon side are rare enough to just grab cookies from additional domain like other person suggested.

But still, I appreciate the effort! It's just not something I think is safe enough to use considering there has been issues with puppeteer's c# wrapper before which had to be debugged and fixed in the upstream code.

I will push fixed version of the application later today.

@AlexCSDev AlexCSDev closed this Apr 5, 2025
@VariableVixen VariableVixen deleted the patch-1 branch April 5, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie Validation Issue
2 participants