Skip to content

Fix cookie initialization #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix cookie initialization #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions UniversalDownloaderPlatform.PuppeteerEngine/PuppeteerCookieRetriever.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ public virtual async Task<CookieContainer> RetrieveCookies()
catch (Exception ex)
{
_logger.Fatal($"Login error: {ex.Message}");
_logger.Fatal($"Full login exception: {ex}");
return null;
}

Expand All @@ -158,9 +159,18 @@ public virtual async Task<CookieContainer> RetrieveCookies()
{
foreach (CookieParam browserCookie in browserCookies)
{
_logger.Debug($"Adding cookie: {browserCookie.Name}");
Cookie cookie = new Cookie(browserCookie.Name, browserCookie.Value, browserCookie.Path, browserCookie.Domain);
cookieContainer.Add(cookie);
try
{
_logger.Debug($"Adding cookie: {browserCookie.Name}");
// Sanitize cookie value to remove characters that are not valid in .NET cookie values
string sanitizedValue = System.Net.WebUtility.UrlEncode(browserCookie.Value);
Cookie cookie = new Cookie(browserCookie.Name, sanitizedValue, browserCookie.Path, browserCookie.Domain);
cookieContainer.Add(cookie);
}
catch (Exception ex)
{
_logger.Warn($"Failed to add cookie {browserCookie.Name}: {ex.Message}. Skipping this cookie.");
}
}
}
else
Expand Down
2 changes: 2 additions & 0 deletions UniversalDownloaderPlatform.PuppeteerEngine/PuppeteerEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ private async Task<IWebBrowser> StartLocalBrowser()
browserArguments.Add($"--proxy-server=\"{_proxyServerAddress}\"");

browserArguments.Add("--disable-blink-features=AutomationControlled");
browserArguments.Add("--no-sandbox");
browserArguments.Add("--disable-dev-shm-usage");

_browser = await PuppeteerSharp.Puppeteer.LaunchAsync(new LaunchOptions
{
Expand Down