Skip to content

fix ci2 #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexInLog merged 31 commits into from
Sep 9, 2025
Merged

fix ci2 #722

Changes from 10 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1f7ce04
jinja2
AlexInLog Sep 4, 2025
b160606
Update ci v2.yml
AlexInLog Sep 4, 2025
f1f5f46
Update ci v2.yml
AlexInLog Sep 4, 2025
4a8849f
Update ci v2.yml
AlexInLog Sep 4, 2025
1d72546
Update ci v2.yml
AlexInLog Sep 4, 2025
097f3b9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 4, 2025
960d5b1
Update ci v2.yml
AlexInLog Sep 5, 2025
71da089
Update ci v2.yml
AlexInLog Sep 5, 2025
2273c54
Update ci v2.yml
AlexInLog Sep 5, 2025
af82c9a
Update ci v2.yml
AlexInLog Sep 5, 2025
5833f8b
Update ci v2.yml
AlexInLog Sep 5, 2025
ac42aa6
Update ci v2.yml
AlexInLog Sep 5, 2025
b13606c
Update conanfile.py
AlexInLog Sep 5, 2025
b477668
Update ci v2.yml
AlexInLog Sep 5, 2025
394508d
Update conanfile.py
AlexInLog Sep 5, 2025
c063a95
Update conanfile.py
AlexInLog Sep 5, 2025
aa66073
Update CMakePresets.json
AlexInLog Sep 5, 2025
260b921
Update conanfile.py
AlexInLog Sep 5, 2025
939f91f
Update conanfile.py
AlexInLog Sep 5, 2025
6ced3b4
Update conanfile.py
AlexInLog Sep 5, 2025
3bcdd0f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 5, 2025
7fc86ec
Update conanfile.py
AlexInLog Sep 5, 2025
b9c1264
Update conanfile.py
AlexInLog Sep 5, 2025
a2c0ce7
Update conanfile.py
AlexInLog Sep 5, 2025
a933311
Update conanfile.py
AlexInLog Sep 5, 2025
7a75fbb
Update conanfile.py
AlexInLog Sep 6, 2025
5c1f160
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 6, 2025
a8ffbec
Update conanfile.py
AlexInLog Sep 6, 2025
ddbe8db
sfml
AlexInLog Sep 6, 2025
ed57cf5
disable windows for now
AlexInLog Sep 9, 2025
bef3e69
Update analyzers.yml
AlexInLog Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,18 @@ jobs:
fetch-depth: 0

- uses: actions/setup-python@v5
with:
python-version: '3.6.x - 3.11.x'
with: { python-version: "3.8" }

- name: get conan
uses: turtlebrowser/get-conan@main

- name: Install deps
if: matrix.config.os == 'ubuntu-22.04'
run: |
sudo apt-get update -q
pip3 install pyyaml jinja2
sudo apt-get install python3-jinja2

@coderabbitai coderabbitai Bot Sep 5, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Fix Python env mismatch and non-interactive install.

  • pip3 and apt install to the system Python, not the 3.8 set by actions/setup-python, which can cause ModuleNotFoundError at runtime.
  • Avoid double-installing Jinja2 (pip + apt). Also, apt install is missing -y and may hang.

Apply:

-    - name: Install deps
-      if: matrix.config.os == 'ubuntu-22.04'
-      run: |
-        sudo apt-get update -q
-        pip3 install pyyaml jinja2
-        sudo apt-get install python3-jinja2
+    - name: Install deps
+      if: matrix.config.os == 'ubuntu-22.04'
+      run: |
+        sudo apt-get update -q
+        python -m pip install --upgrade pip
+        python -m pip install pyyaml jinja2

Optionally mirror this step on macOS/Windows if these deps are needed in those matrix jobs too.

🏁 Script executed:

#!/bin/bash
# Locate usage of actions/setup-python in the CI workflow
grep -R "actions/setup-python" -n .github/workflows/

echo "---- First 100 lines of .github/workflows/ci v2.yml ----"
sed -n '1,100p' ".github/workflows/ci v2.yml"

echo "---- Lines 40-60 of .github/workflows/ci v2.yml ----"
sed -n '40,60p' ".github/workflows/ci v2.yml"

Length of output: 4022

Fix Python package installs in CI

  • Drop the system apt-get install python3-jinja2 (its packages go to the host Python, not the 3.8 from actions/setup-python).
  • Use python -m pip install (and upgrade pip) so dependencies land in the configured Python environment.
-        pip3 install pyyaml jinja2
-        sudo apt-get install python3-jinja2
+        python -m pip install --upgrade pip
+        python -m pip install pyyaml jinja2
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Install deps
if: matrix.config.os == 'ubuntu-22.04'
run: |
sudo apt-get update -q
pip3 install pyyaml jinja2
sudo apt-get install python3-jinja2
- name: Install deps
if: matrix.config.os == 'ubuntu-22.04'
run: |
sudo apt-get update -q
python -m pip install --upgrade pip
python -m pip install pyyaml jinja2
🤖 Prompt for AI Agents 
.github/workflows/ci v2.yml around lines 45 to 51: the workflow currently
installs Python packages via pip3 and a system apt package (python3-jinja2)
which installs into the system Python rather than the actions/setup-python
virtual environment; remove the apt-get install python3-jinja2 line, replace
pip3 install with python -m pip install after running python -m pip install
--upgrade pip to ensure packages are installed into the configured Python (the
same python provided by actions/setup-python), and keep the pip install list
(pyyaml jinja2) using that python -m pip invocation.

- name: check cache
uses: actions/cache@v4
id: check_cache
Expand Down
Loading