draft: add generic layout detection to keyboard-state #4430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xi
force-pushed
the
keyboard-state-layout
branch
from
cec4b5c to
72f872f
Compare
xi
force-pushed
the
keyboard-state-layout
branch
from
72f872f to
03d4b00
Compare
xi
force-pushed
the
keyboard-state-layout
branch
from
03d4b00 to
a2cd205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4101, #4184, and potentially some others. This also has the potential to replace the language modules for sway, hyprland, and niri.
As a first step, I re-implemented the keyboard-state module to use the keyboard information provided by wayland rather than libinput. In a second step, I added layout detection based on that same information.
This works for me (on labwc), but at the same time it sounds too good to be true. So there might well be a huge downside to this approach that I am not aware of.
Currently this is a rough draft and could use some cleanup. But I wanted to get feedback on the general approach before spending too much time.