-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
climate entity for Sonoff TRVZB #1569
base: master
Are you sure you want to change the base?
Conversation
Why did you create a custom BoolSwitch? What's the problem with the one that was? |
XBoolSwitch always toggle "switch" param. But childLock should use childLock param and windowSwitch should change windowSwitch. Logic say it should be "switch" by default or self.param if self.param is set.
|
There is another question. workState and workMode can have values '0' or '1' - string type, not integer. Seems like XBinarySensor is better for them. It is possible to change last line in XBinarySensor ?
|
depending on possibility of changing XBinarySensor code, I will push final TRVZB version with new XHexVoltageTRVZB class for runVoltage and BinarySensor for workMode |
I don't see the reason to have sensors for work state and work mode. |
I finish from my side. Everything works like expected. Please leave workstate sensor, to understand when head is changing the valve state. |
Added climate entity
hvac mode now works like presets (off = off, heat = manual, auto = auto)
fixed Child Lock and Window Switch