Add support for H.265 codec verification #1644
Conversation
|
Chrome 136 is probably going to support H.265 in WebRTC by default. Is this PR needed for functioning with Chrome? |
Answering myself: no. This PR is not needed for go2rtc to work with H265 for WebRTC in Chrome. It's already working now that 136 was pushed to stable. |
these PR not add the support the HEVC, but add suppport that browser automatically use WebRTC and not MSE. But currently it not working... My stream are only MSE with automatic mode, only work WebRTC if i force it. So it definately need it. |
|
Right, thanks for clarifying it. |
| if (!videoCodecs) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Minor indentation issue which I think can be better fixed this way:
| if (!videoCodecs) { | |
| return false; | |
| } | |
| if (!videoCodecs) return false; |
There was a problem hiding this comment.
@seydx, a gentle ping. :)
|
@AlexxIT do you have any concern with this? If previously WebRTC was preferred when streaming H264, then why not prefer it with H265 too when the browser supports it? I believe this PR is a no-brainer and is very important. |
|
I haven't watched it yet. |
This pull request includes updates to the
VideoRTCclass in thewww/video-rtc.jsfile to enhance codec support checking. The most important changes are the addition of a new method to check for H.265 support and the modification of codec priority assignment logic.Enhancements to codec support checking:
www/video-rtc.js: Added a new static methodisH265Supportedto check if H.265/HEVC codecs are supported by the browser.www/video-rtc.js: Updated the condition for assigningmsePriorityfor 'hvc1.' codecs to include a check using the newisH265Supportedmethod.