Added the possibility to filter getSite requests in SiteService according to what the API provides #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding to what the API provides
AFaust
reviewed
Feb 18, 2017
| var hasArguments = false; | ||
| //Add name filter if supplied | ||
| if (payload.nameFilter) { | ||
| if (hasArguments) { |
There was a problem hiding this comment.
I believe the code could be optimised before being merged by using the alfresco/util/urlUtils module to handle the URL construction. Specifically the addFilterQueryParameters operation can already deal with an arbitrary number of payload.dataFilters entries to be added to the URL. That way the service could be easily used as a data source to an alfresco/lists/AlfFilteredList widget.
AFaust
reviewed
Feb 18, 2017
| url += "?"; | ||
| } | ||
| url += "roles=" + payload.roles; | ||
| } | ||
| // TODO: Clean this up. Choose on or other as the Aikau standard. | ||
| var alfResponseTopic = payload.alfResponseTopic || payload.responseTopic; | ||
| var config = { |
There was a problem hiding this comment.
Aren't you missing a change to set the URL inside the config object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in need to filter getSite requests using the filters provided by the API. I added the filtering options to Site Service, however I'm unsure on how to implement a test for this. I could not find any previous tests for the getSites method, getUserSites method or getAdminSites method to use as a template. Please advise on how to proceed or if this commit is good enough.