Fix TypeScript compilation error for y-websocket/bin/utils import#16
Fix TypeScript compilation error for y-websocket/bin/utils import#16
Conversation
Co-authored-by: SMSDAO <[email protected]>
|
✅ Review Update @SMSDAO has submitted a review: approved |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📢 New Pull Request Ready for Review Title: Fix TypeScript compilation error for y-websocket/bin/utils import Please review when you have a chance! 🚀 |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Description
TypeScript compilation failed because
y-websocket(v1.5.0) doesn't provide type definitions for its internal/bin/utilsmodule path, causing the import inserver/yjs-server.tsto error.Type of Change
Related Issues
CI and CodeQL workflows failing with:
Changes Made
server/types/y-websocket-utils.d.tswith type declarations forsetupWSConnectionfunction.gitignoreto exemptserver/types/**/*.d.tsfrom the global*.d.tsignore ruleType declaration provides:
Testing
Test Coverage
tsc --project tsconfig.server.jsonpassesnpm run buildcompletes without errorsScreenshots/Videos
N/A
Checklist
Deployment Notes
None. Type declarations are compile-time only.
Additional Context
The
tsconfig.server.jsonalready includes"server/**/*", so the new declaration file is automatically discovered. No configuration changes needed beyond the.gitignoreexception.Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.