Skip to content

Conversation

SonZon2896
Copy link

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 71. Check the log or trigger a new build to see more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 68. Check the log or trigger a new build to see more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 60. Check the log or trigger a new build to see more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 55. Check the log or trigger a new build to see more.

std::vector<double> BellmanFordAlgorithm(const WeightedGraph& graph,
int start_id) {
int n = graph.GetVerts();
std::vector<double> pathLength(n, DBL_MAX);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не по кодстайлу( path_length правильно, ни и везде

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

имена файлов должны быть в стиле переменных, а расширение hpp( bellman_ford.hpp

pathLength[start_id] = 0;
int this_id = start_id;
int counter = 0;
for (; true;) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тогда уж for (;;)

@@ -0,0 +1,31 @@
#include <GraphDFSIterator.h>

GraphDFSIterator::GraphDFSIterator(const WeightedGraph* const graph,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

красивее было бы вот так:
GraphDFSIterator::GraphDFSIterator(...) : start_id(start_id), graph(),... {}

TEST(Test, Simple) {
ASSERT_EQ(1, 1); // Stack []
}
TEST(TopologicalSortTest, Simple) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тестов бы побольше(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants