Repository navigation
fix(security): update Go toolchains and networking dependencies - #9680
Open
okatu-loli wants to merge 1 commit into
Open
okatu-loli wants to merge 1 commit into
okatu-loli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.66.0's Linux amd64 and Darwin arm64 binaries were built with Go 1.26.6 and still contain x/net v0.48.0 and x/crypto v0.46.0. They predate the October HTTP fixes and CVE-2026-111943 certificate distrust mitigation. AList also calls the ServeContent entry point affected by CVE-2026-78667.
This updates the minimum Go version and every Go workflow to 1.26.10, x/net to v0.60.0, and x/crypto to v0.57.0 (required by x/net), together with their required x/* dependencies. The standalone Docker builder also uses Go 1.26.10.
The stable release's xgo container chooses its own Go independently of setup-go. Since upstream does not currently publish a 1.26.10 xgo image, retain its cross compilers and replace the Go installation with the official 1.26.10 distribution. Both development and stable xgo builds use this image. A new CI job builds Linux amd64, Windows amd64 and Darwin arm64 binaries and checks their embedded Go, x/net and x/crypto versions. Release-script tests cover container build/compiler failures before packaging; their FreeBSD probe mock is also brought in line with the existing range probes (overlaps #9679).
Validation:
-tags=jsoniter; binaryversionand embedded build information verified.go test -vet=off -tags=jsoniter -run '^$' ./...../server/webdav/... ./pkg/gowebdav ./pkg/utils.Known validation limits: default test vet reports existing formatting diagnostics in unchanged code.
internal/archive/tool'sTestSecureJoin/drivefails on macOS in both the unmodified base and this branch. Local full xgo image verification is not yet complete; the new cross-platform CI job verifies the actual artifacts. This PR does not publish a release; after merging and checking the full release matrix, these changes are suitable for a v3.66.1 security patch release.References: Go certificate mitigation, Range DoS, x/net announcement, SSH announcement.