Add comprehensive GitLab webhook setup instructions for enterprise deployments#243
Draft
jpshackelford wants to merge 1 commit intomainfrom
Draft
Add comprehensive GitLab webhook setup instructions for enterprise deployments#243jpshackelford wants to merge 1 commit intomainfrom
jpshackelford wants to merge 1 commit intomainfrom
Conversation
- Add webhook secret generation to GitLab app setup - Include webhook-secret in gitlab-app Kubernetes secret - Add complete webhook setup section with two options: 1. Automated webhook installation using Python script 2. Manual webhook configuration through GitLab UI - Provide CronJob configuration for ongoing webhook management - Include detailed troubleshooting guide for webhook issues - Document technical specifications and event types - Add debugging instructions for webhook problems This addresses the missing GitLab webhook documentation that was incomplete compared to the GitHub webhook setup instructions. Co-authored-by: openhands <openhands@all-hands.dev>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the incomplete GitLab webhook documentation in the OpenHands Cloud Helm chart README. While the GitHub section includes comprehensive webhook setup instructions, the GitLab section was missing critical webhook configuration steps needed for enterprise deployments.
Problem
The current GitLab integration documentation only covers OAuth application setup but lacks webhook configuration instructions. This means:
@openhandsmentions in issues/MRsChanges Made
1. Enhanced GitLab Application Setup
export GITLAB_WEBHOOK_SECRET=head /dev/urandom | tr -dc A-Za-z0-9 | head -c 32webhook-secretin thegitlab-appsecret2. Comprehensive Webhook Setup Section
Added a complete "Setting Up Webhooks for Issue and PR Integration" section with:
Option 1: Automated Webhook Installation
python enterprise/sync/install_gitlab_webhooks.pyOption 2: Manual Webhook Configuration
3. Technical Documentation
https://{your-domain}/integration/gitlab/events4. Troubleshooting Guide
Technical Analysis
The documentation is based on analysis of the OpenHands codebase:
enterprise/sync/install_gitlab_webhooks.py- Automated webhook installation scriptenterprise/integrations/gitlab/gitlab_service.py- Webhook installation logicenterprise/server/routes/integration/gitlab.py-/integration/gitlab/eventsrouteenterprise/storage/gitlab_webhook.py- Webhook storage schemaenterprise/integrations/utils.py-GITLAB_WEBHOOK_URLconstantWebhook Installation Flow
gitlab_webhooktable/integration/gitlab/eventsendpointBenefits
Testing
References
All documentation is based on analysis of the following OpenHands source files:
enterprise/sync/install_gitlab_webhooks.py- Webhook installation automationenterprise/integrations/gitlab/gitlab_service.py- GitLab API integrationenterprise/integrations/utils.py- Webhook URL configurationenterprise/storage/gitlab_webhook_store.py- Database operationsenterprise/server/routes/integration/gitlab.py- Webhook event processingThis ensures all documented procedures are factually accurate and match the actual implementation.
@jpshackelford can click here to continue refining the PR