Skip to content

Add preflight check for external postgres permissions #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashjones-replicated wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add preflight check for external postgres permissions #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions charts/openhands/templates/troubleshoot/_shared.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,37 @@
password:
secretName: {{ .existingSecret | default "postgres-password" }}
secretKey: {{ .existingSecretPasswordKey | default "password" }}
- runPod:
name: postgres-permissions-check
namespace: {{ $.Release.Namespace }}
podSpec:
containers:
- name: postgres-check
image: postgres:14-alpine
command:
- /bin/sh
- -c
- >-
psql -t -A -c
"SELECT 'SCHEMA_CREATE: ' || has_schema_privilege(current_user, 'public', 'CREATE')::text
UNION ALL
SELECT 'SCHEMA_USAGE: ' || has_schema_privilege(current_user, 'public', 'USAGE')::text
UNION ALL
SELECT 'DB_CREATE: ' || has_database_privilege(current_user, current_database(), 'CREATE')::text"
env:
- name: PGPASSWORD
valueFrom:
secretKeyRef:
name: {{ .existingSecret | default "postgres-password" }}
key: {{ .existingSecretPasswordKey | default "password" }}
- name: PGUSER
value: {{ .username | default "postgres" }}
- name: PGHOST
value: {{ .host }}
- name: PGPORT
value: "{{ .port | default 5432 }}"
- name: PGDATABASE
value: {{ .database | default "openhands" }}
{{- end }}
{{- end }}
{{- end }}
Expand Down Expand Up @@ -71,5 +102,38 @@
- pass:
when: "connected == true"
message: "External PostgreSQL database is healthy"
- textAnalyze:
checkName: "External PostgreSQL Schema CREATE Permission"
fileName: postgres-permissions-check/postgres-permissions-check.log
regex: "SCHEMA_CREATE: true"
outcomes:
- pass:
when: "true"
message: "{{ .Values.externalDatabase.username | default "postgres" }} has CREATE on public schema ({{ .Values.externalDatabase.database | default "openhands" }})"
- fail:
when: "false"
message: "{{ .Values.externalDatabase.username | default "postgres" }} missing CREATE on public schema ({{ .Values.externalDatabase.database | default "openhands" }})"
- textAnalyze:
checkName: "External PostgreSQL Schema USAGE Permission"
fileName: postgres-permissions-check/postgres-permissions-check.log
regex: "SCHEMA_USAGE: true"
outcomes:
- pass:
when: "true"
message: "{{ .Values.externalDatabase.username | default "postgres" }} has USAGE on public schema ({{ .Values.externalDatabase.database | default "openhands" }})"
- fail:
when: "false"
message: "{{ .Values.externalDatabase.username | default "postgres" }} missing USAGE on public schema ({{ .Values.externalDatabase.database | default "openhands" }})"
- textAnalyze:
checkName: "External PostgreSQL Database CREATE Permission"
fileName: postgres-permissions-check/postgres-permissions-check.log
regex: "DB_CREATE: true"
outcomes:
- pass:
when: "true"
message: "{{ .Values.externalDatabase.username | default "postgres" }} has CREATE on database ({{ .Values.externalDatabase.database | default "openhands" }})"
- fail:
when: "false"
message: "{{ .Values.externalDatabase.username | default "postgres" }} missing CREATE on database ({{ .Values.externalDatabase.database | default "openhands" }})"
{{- end }}
{{- end -}}