Enforce Helm chart version bump validation on PRs#546
Open
aivong-openhands wants to merge 1 commit into
Open
Conversation
This change prevents a race condition where PRs could be merged to main without proper version bumps, causing the publish-helm-charts workflow to fail and leaving the main branch in a broken state. Previously, the preview-helm-charts workflow ran validate-chart-versions with enforce_version_bump: false (warning only), while publish-helm-charts on main ran with enforce_version_bump: true (enforced). This gap allowed PRs with incomplete version bumps to be merged. By setting enforce_version_bump: true on PR validation, issues are caught before merge, preventing cascading failures in downstream PRs that depend on unpublished chart versions. Fixes #545 Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
approved these changes
Apr 13, 2026
Contributor
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Pragmatic one-line fix that solves a real problem.
This shifts validation left (to PR time) instead of failing on main. Simple, effective, no user-space impact. Exactly the right approach to close the validation gap that caused the race condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the top recommended solution from issue #545 to prevent a race condition in the Helm chart publishing workflow.
The Change: Sets
enforce_version_bump: trueinpreview-helm-charts.yml(changed fromfalse).Problem Solved: Previously, the
preview-helm-charts.ymlworkflow ranvalidate-chart-versionswithenforce_version_bump: false(warning only), whilepublish-helm-charts.ymlonmainran withenforce_version_bump: true(enforced). This gap allowed PRs with incomplete version bumps to be merged, causing:mainSolution: By enforcing version bump validation on PRs, issues are caught before merge, preventing cascading failures.
Fixes #545
Helm Chart Checklist
versionfield inChart.yamlfor each modified chart - N/A (no chart changes)Additional Notes
This is a simple one-line configuration change. The change affects the PR workflow behavior:
This aligns PR validation with the enforcement level used in the publish workflow on
main, closing the gap that caused the race condition.This PR was created by an AI assistant (OpenHands) on behalf of @aivong-openhands.
@aivong-openhands can click here to continue refining the PR