Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpt_mdc1200.c: Address issue app_rpt: Incorrect usage of sizeof() function #207 #473

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rpt_mdc1200.c: Address issue app_rpt: Incorrect usage of sizeof() function #207 #473

wants to merge 2 commits into from

Conversation

mkmer
Copy link
Collaborator

@mkmer mkmer commented Jan 28, 2025 •
edited
Loading

Addressing identified solution in issue fixes #207

@mkmer mkmer added the bug Something isn't working label Jan 28, 2025
@Allan-N Allan-N requested a review from InterLinked1 January 28, 2025 18:43
@mkmer mkmer added the code quality Improvments around code quality without functional changes label Jan 30, 2025
@Allan-N Allan-N requested a review from KB4MDD February 17, 2025 16:17
InterLinked1
InterLinked1 requested changes Feb 17, 2025
View reviewed changes
InterLinked1
InterLinked1 reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@InterLinked1 InterLinked1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you also update your commit message formatting, e.g. to close the linked issue? Right now that's only in the PR description

@mkmer
rpt_mdc1200.c: Address Incorrect usage of sizeof() function Issue All…
3099d1e 
…StarLink#207

               Remove unnecessary memset
               Remove extra log for ast_calloc failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InterLinked1 InterLinked1 InterLinked1 requested changes

@KB4MDD KB4MDD KB4MDD approved these changes

@Allan-N Allan-N Allan-N approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@mkmer mkmer

Labels
bug Something isn't working code quality Improvments around code quality without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app_rpt: Incorrect usage of sizeof() function
4 participants
@mkmer @KB4MDD @InterLinked1 @Allan-N