Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_rpt.c: perform_statpost - add verbose text to errors #499

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

mkmer
Copy link
Collaborator

@mkmer mkmer commented Feb 19, 2025

Provide text error descriptions from the curl library.
Closes issue #490

@mkmer mkmer added the enhancement New feature or request label Feb 19, 2025
@mkmer mkmer self-assigned this Feb 19, 2025
@mkmer mkmer marked this pull request as draft February 19, 2025 15:22
Copy link
Member

@InterLinked1 InterLinked1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the error from the library include the number in it? If not, I think we should print both the number and the error name

@mkmer mkmer force-pushed the curl-extended-diag branch from b698a9f to 3381766 Compare February 19, 2025 17:41
@mkmer
Copy link
Collaborator Author

mkmer commented Feb 19, 2025

Does the error from the library include the number in it? If not, I think we should print both the number and the error name

Actually, there are library errors and web link errors -> that's why I changed it to draft.
We have to capture the response message text in the writefunction to get the web error text.

For web errors it will look something like this:
<http link> failed with code 401 : Unauthorized

For library errors it will look like this:

<http link> failed with error: Could not resolve host: tats.allstarlink.org

I don't believe the library error values make much sense to share (do they?)

@Allan-N Allan-N self-requested a review February 19, 2025 17:53
@mkmer mkmer force-pushed the curl-extended-diag branch 2 times, most recently from be37f34 to 8827366 Compare February 19, 2025 18:30
@mkmer mkmer linked an issue Feb 19, 2025 that may be closed by this pull request
@mkmer mkmer marked this pull request as ready for review February 19, 2025 18:47
@mkmer mkmer force-pushed the curl-extended-diag branch 2 times, most recently from 72545f7 to 3e5b927 Compare February 19, 2025 22:46
@mkmer mkmer force-pushed the curl-extended-diag branch 3 times, most recently from 3493816 to c2e71bf Compare February 19, 2025 23:09
@Allan-N Allan-N merged commit 879b93b into AllStarLink:master Feb 20, 2025
2 checks passed
@Allan-N Allan-N changed the title app_rpt.c: perform_statpost - add verbose text to errors. app_rpt.c: perform_statpost - add verbose text to errors Feb 20, 2025
@mkmer mkmer deleted the curl-extended-diag branch February 20, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The perform_statpost function needs better explanation of errors
3 participants