Skip to content

Conversation

@pgarrison
Copy link
Collaborator

Purpose

The current README instructions ignore the pdm.lock file and install from pyproject.toml, which does not create reproducible environments. We may not expect all users to have pdm, though.

Changes

  • Export the pdm.lock to requirements.txt format, and update the instructions to use it.
  • Add github actions to enforce that the requirements.txt is up to date with the pdm.lock and that the pdm.lock is up to date with the pyproject.toml.

Testing

  • I did the steps python -m venv venv, source venv/bin/activate, and pip install -r requirements.txt, but didn't run any code in that new environment.
  • The github actions failed (as expected) before updating pdm.lock and now succeed

@pgarrison pgarrison marked this pull request as ready for review November 7, 2025 22:37
@smishra3 smishra3 requested a review from kiryteo November 13, 2025 17:45
@smishra3 smishra3 closed this Nov 18, 2025
@smishra3 smishra3 reopened this Nov 18, 2025
@pgarrison pgarrison merged commit 403839b into reSub-v1 Nov 18, 2025
2 checks passed
@pgarrison pgarrison deleted the feature/pdm branch November 18, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants