Skip to content

update gradient strength #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rugeli wants to merge 5 commits into from
Closed

update gradient strength #110

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcd1ae0
update gradient strength
rugeli Oct 13, 2025
6ba5c8e
use constants
rugeli Oct 15, 2025
f0bdfd8
round to 4 decimal place fo store
rugeli Oct 15, 2025
778f99c
tests
rugeli Oct 15, 2025
2027e1c
temp fix test, rename constants, add accurate tooltip
rugeli Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/utils/gradient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,17 @@ interface GradientStrength {
};

// Helpers: store <-> UI mapping
// Store: "smaller = stronger" (e.g., decay length). UI: "bigger = stronger" (0..1).
export const toUi = (storeVal: number) => Number((1 - storeVal).toFixed(2));
export const toStore = (uiVal: number) => Number((1 - uiVal).toFixed(2));
// Store: "smaller = stronger" (e.g., decay length). UI: "bigger = stronger" (0.01-100). decay_length = 1 / gradient strength
const MAX_GRADIENT_STRENGTH = 100;

export const toUi = (storeVal: number) => {
if (storeVal <= 0) return MAX_GRADIENT_STRENGTH;
return Number((1 / storeVal).toFixed(2));
};
export const toStore = (uiVal: number) => {
if (uiVal <= 0) return MAX_GRADIENT_STRENGTH;
return Number((1 / uiVal).toFixed(2));
};
export const round2 = (n: number) => Number(n.toFixed(2));


Expand Down Expand Up @@ -60,8 +68,8 @@ export function deriveGradientStrength(
): GradientStrength | undefined {
if (!opt?.strength_path) return undefined;

const storeMin = opt.strength_min ?? 0;
const storeMax = opt.strength_max ?? 0.99;
const storeMin = opt.strength_min ?? 0.01;
const storeMax = opt.strength_max ?? 100;
Copy link
Contributor

@ascibisz ascibisz Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since we just defined MAX_GRADIENT_STRENGTH = 100, should we use that here?

Copy link
Contributor Author

@rugeli rugeli Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! Updating it now


const uiMin = toUi(storeMax);
const uiMax = toUi(storeMin);
Expand Down