Skip to content

Conversation

@ascibisz
Copy link
Contributor

@ascibisz ascibisz commented Oct 23, 2025

Problem

Currently, when a user wants to pack an edited recipe , we upload the edited recipe to firebase, pass that reference to the server, and then the server retrieves the recipe from firebase. To minimize firebase calls and improve efficiency of the client, we're changing that flow to instead send the edited recipe JSON as the body of the packing request to the server.

Part of this ticket

Solution

For edited recipes, don't send a recipe URL param and send the recipe JSON in the body of the POST request to the server.

Depends on this cellpack ticket, since the server currently only accepts firebase paths and local file paths to recipes

Once the above cellpack ticket is merged, we will need to redeploy the server and update the API gateway to pass the body along.

DON'T MERGE until the above server steps have been completed!! Packing editable recipes won't work with this code until those steps are complete!!!

@ascibisz ascibisz force-pushed the feature/send-recipe-json-to-server branch from d47ed9d to 1b766b7 Compare October 23, 2025 20:50
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.8% 363 / 1525
🔵 Statements 23.8% 363 / 1525
🔵 Functions 41.81% 23 / 55
🔵 Branches 72.07% 80 / 111
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/App.tsx 0% 0% 0% 0% 1-10, 12-13, 15-21, 23, 25-27, 29-35, 37-43, 45-76, 78-86, 88-113, 115-119, 121-125, 127-146, 148, 150
src/constants/aws.ts 0% 100% 100% 0% 2, 5, 7-20, 22-24, 26-28, 31-37
src/utils/firebase.ts 34.45% 62.5% 28.57% 34.45% 32-33, 38-39, 73-75, 78-83, 86-90, 93-98, 102-110, 113-115, 118-120, 123-142, 145-161, 175-179, 181-188, 190, 192-194, 196-199
Generated in workflow #101

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://AllenCell.github.io/cellpack-client/pr-preview/pr-123/

Built to branch gh-pages at 2025-10-23 21:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ascibisz ascibisz changed the title for edited recipes, send json version of recipe to server rather than… Send Edited Recipe JSON in Request Body Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants