change scroll behavior #131
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #130 by modifying scroll behavior across the application. The changes prevent unwanted scrollbars from appearing in specific contexts while ensuring scrollbars are visible when viewing full recipes.
Key Changes:
- Removed automatic overflow from the JSONViewer component
- Updated main container scroll behavior to hide horizontal scrollbars while keeping vertical scroll enabled
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/JSONViewer/style.css | Removed overflow: auto to prevent unnecessary scrollbars in the JSONViewer component |
| src/App.css | Changed from overflow: scroll to overflow-x: hidden and overflow-y: auto to hide horizontal scrollbars while enabling vertical scrolling only when needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
File CoverageNo changed files found. |
|
rugeli
left a comment
rugeli
left a comment
There was a problem hiding this comment.
this bug didn’t show up for me either, not in the last merged pr or in this one(on Mac).
I also tested it on Windows: when the text isn’t scrollable, there’s no persistent scrollbar, but when I shrink the window or the text is long enough to scroll, it appears (see screenshot). Looks like that's the expected scrollbar behavior on Windows
Problem
closes #130 (hopefully)
This bug doesn't show up for me, so it would be helpful if someone that did can verify this fixes the issue
Solution
changed the scroll css settings
Type of change
Please delete options that are not relevant.
Steps to Verify: