-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/autoselect #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/autoselect #132
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements autoselection of a default recipe ("peroxisome_v_gradient_packing") on application load. The implementation changes the recipe identification system from using display names to recipe IDs as the primary identifier throughout the application.
Key changes:
- Recipe selection now uses recipe IDs instead of display names as the primary identifier
- Default recipe is automatically selected in the initial state
- Display names are preserved for UI presentation in the dropdown
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/firebase.ts | Refactored getPackingInputsDict to use recipe IDs as dictionary keys instead of names; code formatting improvements |
| src/types/index.ts | Added optional name field to PackingInputs type; formatting fixes |
| src/state/store.ts | Removed selectedInputName state, replaced with recipe ID-based selection; set default recipe ID; renamed selectInput to selectRecipe |
| src/components/PackingInput/index.tsx | Updated to use selectRecipe action and pass defaultValue to Dropdown |
| src/components/Dropdown/index.tsx | Modified to display names from PackingInputs and use recipe IDs as values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Problem
closes #117
Solution
added a recipe to the default state
I also removed the recipe display name from the store and am now only using the id as an identification. The only place the name shows up is in the dropdown
Type of change
Please delete options that are not relevant.
Change summary:
Steps to Verify: