generated from allen-cell-animated/github-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/show precomputed results tweaks #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
bd571c5
use result_path from firebase to display result in viewer upon selection
ascibisz fdba1c7
working but many updates
meganrm c05b6f9
reduce rerenders
meganrm efa879f
remove log
meganrm cd11abb
clean up selectors
meganrm a9b3864
use runtime from results
meganrm 3aa354c
reduce redundant state
meganrm dae5a6a
move more things to the store
meganrm 2353947
remove unnecessary additional field from store
ascibisz 1a595f1
Merge branch 'feature/show-precomputed-results' into feature/show-pre…
meganrm 774e287
remove merge resolve error
meganrm dd22a51
use empty result obj
meganrm 9517f3f
fix included param
meganrm 893bb5a
move hooks to top of function
meganrm 3e50510
Update src/state/store.ts
meganrm a157b63
use empty packing result object
meganrm 369421c
Merge branch 'feature/show-precomputed-results-tweaks' of https://git…
meganrm 72092e3
use zero
meganrm 29f22d1
Merge branch 'main' of https://github.com/AllenCell/cellpack-client i…
meganrm dc5b4b2
remove dup typing
meganrm 0b84b49
better error message
meganrm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,17 @@ | ||
| import { SIMULARIUM_EMBED_URL } from "../../constants/urls"; | ||
| import { useResultUrl } from "../../state/store"; | ||
| import "./style.css"; | ||
|
|
||
| interface ViewerProps { | ||
| resultUrl: string; | ||
| } | ||
|
|
||
| const Viewer = (props: ViewerProps): JSX.Element => { | ||
| const { resultUrl } = props; | ||
| const Viewer = (): JSX.Element => { | ||
| const resultUrl = useResultUrl(); | ||
| return ( | ||
| <div className="viewer-container"> | ||
| <iframe className="simularium-embed" src={resultUrl} /> | ||
| <iframe | ||
| className="simularium-embed" | ||
| src={`${SIMULARIUM_EMBED_URL}${resultUrl}`} | ||
| /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Viewer; | ||
| export default Viewer; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ export interface Document { | |
| recipe?: string; | ||
| config?: string; | ||
| editable_fields?: string[]; | ||
| result_path?: string; | ||
| } | ||
|
|
||
| export type FirestoreDoc = Document & { | ||
|
|
@@ -15,10 +16,11 @@ export interface Dictionary<T> { | |
| [Key: string]: T; | ||
| } | ||
|
|
||
| export type PackingInputs = { | ||
| export type RecipeManifest = { | ||
| name?: string; | ||
| config: string; | ||
| recipe: string; | ||
| defaultResultPath?: string; | ||
| editable_fields?: EditableField[]; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should use camel case here? |
||
| }; | ||
|
|
||
|
|
@@ -29,6 +31,14 @@ export type JobStatusObject = { | |
| result_path: string; | ||
| }; | ||
|
|
||
| export type PackingResults = { | ||
| jobId: string; | ||
| jobLogs: string; | ||
| resultUrl: string; | ||
| runTime: number; | ||
| outputDir: string; | ||
| }; | ||
|
|
||
| export type EditableField = { | ||
| id: string; | ||
| name: string; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.