Skip to content

Conversation

@rugeli
Copy link
Contributor

@rugeli rugeli commented Nov 7, 2025

Problem

What is the problem this work solves, including
closes #147

Solution

What I/we did to solve this problem

  • removed default vite favicon and replaced it with the cellPACK icon (48x48 dark filled png)
  • added a favicon.ico fallback for browsers that look for it by default

@thao-do also provided 32x32 png version, we can swap them in if the current one doesn't look ideal to the team

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Steps to Verify:

  1. go to preview site, verify the favicon's size, color, res, etc

Screenshots (optional):

google chrome
Screenshot 2025-11-07 at 11 20 18 AM

Screenshot 2025-11-07 at 11 19 06 AM

firefox
Screenshot 2025-11-07 at 11 19 29 AM

Screenshot 2025-11-07 at 11 19 41 AM

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.39% 365 / 1706
🔵 Statements 21.39% 365 / 1706
🔵 Functions 40.35% 23 / 57
🔵 Branches 71.42% 80 / 112
File CoverageNo changed files found.
Generated in workflow #125

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-11-07 21:55 UTC

Copy link
Contributor

@ascibisz ascibisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@thao-do thao-do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to add that this should also works for dark background - it's hard to tell on the light background but it also has a very light fill. Eventually we'll consult @gj210 for optimizing the icon (details, line weight, etc.) for this tiny size but for now this is good. Thank you!

@rugeli rugeli merged commit e000e1c into main Nov 7, 2025
2 checks passed
@rugeli rugeli deleted the feature/favicon branch November 7, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

favicon

5 participants