-
Notifications
You must be signed in to change notification settings - Fork 0
handle case of no gradient #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
rugeli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played around on the preview site, No Gradient worked well, and packing_mode in the full data updated to random in real time!
Just noticed one mismatch: after selecting No Gradient, the gradient field in the full recipe data still shows the previously selected gradient(see screenshot). It'd be clearer to either update the field value to no_gradient or hide it altogether, whichever is simpler. Lmk what you think!

interim17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking question.
@rugeli I wasn't able to quickly find a solution that wouldn't throw an error in cellpack (setting |

Problem
Right now, if you select "No Gradient" from the gradient dropdown, it fails to show up as the selected option in the input fields form.
Ticket
Solution
I did verify that the recipe JSON was being updated appropriately when the user selects "No Gradient", so all I needed to change was how we're determining which gradient option is selected.
There are two parts of the recipe JSON that are updated based on recipe selection, the
gradientfield that is set tomembrane_gradientornucleus_gradientetc, and thepacking_modefield which is either set torandomfor the "No Gradient" case orgradientfor all other cases. We hadn't been looking atpacking_modewhen determining what gradient option is selected, but that's the only way to determine if "No Gradient" is selected, so I added some logic to check this field as well.