Skip to content

disable button if no parameters have been changed #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrm merged 14 commits into from
Nov 14, 2025
Merged

disable button if no parameters have been changed #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e07c9c6
use object instead of string as single source of truth
interim17 Nov 10, 2025
2decf90
Merge branch 'feature/show-precomputed-results-tweaks' of https://git…
interim17 Nov 10, 2025
3a02c07
use displayName
interim17 Nov 10, 2025
ed152a6
add second call of editRecipe for gradient value
interim17 Nov 11, 2025
9de4abf
move building current recipe object from util into selector
interim17 Nov 11, 2025
656b14a
Merge branch 'main' of https://github.com/mesoscope/cellpack-client i…
interim17 Nov 11, 2025
faf266d
revert to using utility to build recipe objects
interim17 Nov 12, 2025
8f5f11a
add documenting comment to buildRecipeObject
interim17 Nov 12, 2025
98e37c5
Merge branch 'main' of https://github.com/mesoscope/cellpack-client i…
interim17 Nov 13, 2025
f6f6dca
rename and adjust typing of recipe object utility
interim17 Nov 13, 2025
814d1f2
disable button if no parameters have been changed
meganrm Nov 13, 2025
9566b3f
Merge branch 'main' of https://github.com/AllenCell/cellpack-client i…
meganrm Nov 13, 2025
34b4a89
small styling fixes
meganrm Nov 13, 2025
88a36ca
Merge branch 'main' of https://github.com/AllenCell/cellpack-client i…
meganrm Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
align-items: center;
height: var(--header-height);
box-sizing: border-box;
border-bottom: 1px solid;
border-bottom: 1px solid #ddd;
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CSS color change is unrelated to the PR's purpose of disabling the button based on parameter changes. This change should be removed or submitted in a separate PR.

Suggested change
border-bottom: 1px solid #ddd;

Copilot uses AI. Check for mistakes.
}

.sider {
Expand Down
26 changes: 17 additions & 9 deletions src/components/RecipeForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { Button } from "antd";
import { Button, Tooltip } from "antd";
import InputSwitch from "../InputSwitch";
import "./style.css";
import {
useSelectedRecipeId,
useFieldsToDisplay,
useIsPacking,
useIsOriginalRecipe,
} from "../../state/store";

interface RecipeFormProps {
Expand All @@ -15,6 +16,7 @@ const RecipeForm = ({ onStartPacking }: RecipeFormProps) => {
const recipeId = useSelectedRecipeId();
const fieldsToDisplay = useFieldsToDisplay();
const isPacking = useIsPacking();
const isOriginalRecipe = useIsOriginalRecipe();

return (
<div className="recipe-form">
Expand All @@ -39,15 +41,21 @@ const RecipeForm = ({ onStartPacking }: RecipeFormProps) => {
</div>
)}
{recipeId && (
<Button
onClick={onStartPacking}
color="primary"
variant="filled"
disabled={isPacking}
style={{ width: "100%" }}
<Tooltip
title={
isOriginalRecipe ? "Adjust any parameter to re-run" : ""
}
>
Re-run
</Button>
<Button
onClick={onStartPacking}
color="primary"
variant="filled"
disabled={isPacking || isOriginalRecipe}
style={{ width: "100%" }}
>
<strong>Re-run</strong>
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button text change from 'Re-run' to 'Re-run' is unrelated to the PR's purpose of disabling the button when parameters haven't changed. This styling change should be removed or submitted in a separate PR focused on UI improvements.

Suggested change
<strong>Re-run</strong>
Re-run

Copilot uses AI. Check for mistakes.
</Button>
</Tooltip>
)}
</div>
);
Expand Down
15 changes: 11 additions & 4 deletions src/state/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,11 @@ export const useRecipeStore = create<RecipeStore>()(
const remainingRecipesToLoad = recipeIds.filter(
(id) => id !== initialIdToLoad
);
Promise.all(remainingRecipesToLoad.map((id) => loadRecipe(id)))
.catch((err) => {
console.error("Error loading remaining recipes:", err);
});
Promise.all(
remainingRecipesToLoad.map((id) => loadRecipe(id))
).catch((err) => {
console.error("Error loading remaining recipes:", err);
});
},

selectRecipe: async (recipeId) => {
Expand Down Expand Up @@ -340,6 +341,12 @@ export const useResultUrl = () => {
return path;
};

export const useIsOriginalRecipe = () => {
const recipe = useCurrentRecipeData();
if (!recipe) return true;
return Object.keys(recipe.edits).length === 0;
};

Comment on lines +344 to +349
Copy link
Contributor

@interim17 interim17 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I reintroduced useIsModified in essentially the same way as this in #154

Assuming this merges first I'll bring these changes over and use this selector

// Action selectors
export const useLoadInputOptions = () =>
useRecipeStore((s) => s.loadInputOptions);
Expand Down