remove strong and weak labels on gradient strength #159
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
|
ascibisz
changed the title
… firebase when available
| height: calc( | ||
| 100vh - var(--header-height) - var(--recipe-select-height) - | ||
| var(--tab-height) - var(--footer-height) | ||
| var(--tab-height) - var(--footer-height) - var(--description-height) |
There was a problem hiding this comment.
super nit: when switching from any recipe to multi-spheres, the re-run button shifts slightly (not fully fixed) because that recipe has more editable fields. I don’t think it’s blocking, just something I noticed.
There was a problem hiding this comment.
Ah good catch. I think that we'll address this in some follow up work for improvements to the scrollable area next week, I'm kinda leaving it at "the re-run button is consistently viewable, that's good enough for today"
| --recipe-select-height: 52px; | ||
| --tab-height: 62px; | ||
| --footer-height: 64px; | ||
| --description-height: 102px; |
There was a problem hiding this comment.
I'm working on a dynamic fix for this
There was a problem hiding this comment.
awesome - Thao had some comments in slack in cellpack-site about improvements for the scrollable area, I'm just not a strong enough front end developer to knock that out in time today without introducing other bugs, so I did this bandaid fix for now
Problem
Saurabh's feedback in slack indicates that the strong / weak labels on gradient strength are misleading as they stand. We may add them back in with some other changes to wording, but for now we're just removing them to eliminate confusion.
Critical change:
Solution
Removed labels for weak and strong on for gradient strength and changed gradient strength description (both in fallback case in code and in firebase)
Based on feedback, also