Skip to content

Conversation

@ascibisz
Copy link
Contributor

Problem

We don't want the users manually selecting their configs, we can do that for them
Link to story or ticket

Solution

  • Created a new collection in firebase, called example_packings, where each entry contains the ID of a recipe that's in the recipes collection, the ID of a config that's in the configs collection, and a human readable name. These together represent one entity that can be selected as the inputs to a packing on the cellpack client
  • Adjusted the cellpack client code so now the "select a recipe" drop down uses the names in the example_packings collection. When a user selects one of those options, the associated recipe ID and config ID are tracked and submitted when a user hits submit
  • Removed the display of config selection and config JSON
  • Minor formatting changes since we now only have one JSON object being displayed

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-08-27 17:57 UTC

@ascibisz ascibisz marked this pull request as ready for review August 21, 2025 22:05
@ascibisz ascibisz linked an issue Aug 21, 2025 that may be closed by this pull request
@ascibisz ascibisz requested a review from rugeli August 25, 2025 18:26
Copy link
Contributor

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice! Worked on my end, except two minor issues, lgtm!

@ascibisz ascibisz merged commit 2583ed3 into main Aug 27, 2025
2 checks passed
@ascibisz ascibisz deleted the feature/hide-config-file branch August 27, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Config Selection

3 participants