Condition tifffile pin on python version #498
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Note: the only changes I made were to
pyproject.toml, the other files were automatically updated by a GH workflow, it seems.Recently,
aicsfiles==8.1.0was released, which introduced a dependency onbioio>=3.0.0. The endo team currently uses an environment that requires bothaicsfilesandcyto-dl. @jessicasyu found the following problem when testing the endo code withaicsfiles==8.1.0:uvwas able to install all required packages without issuefrom bioio.writers import OmeTiffWriteryieldedImportError: cannot import name 'OmeTiffWriter' from 'bioio.writers'This appears to be caused by the following:
cyto-dl==0.6.1has the pintifffile>=2024.0.0,<2025.2.18bioio-ome-tiff==1.4.0has the pin'tifffile[zarr]>=2022.4.22,<2025.1.10; python_version < "3.11"','tifffile[zarr]>=2025.5.21; python_version >= "3.11"bioio-ome-tiff,1.1.0OmeTiffWriterfrombioiotobioio-ome-tiff'bioio=3.0.0(fromaicsfiles==8.1.0), andbioio-ome-tiff==1.1.0; both of these versions believe the other is responsible for providingOmeTiffWriter, so we get our failureI've concluded from these two PRs (cyto-dl, bioio-ome-tiff) that both repos were trying to solve the same problem (failure of
OmeTiffWriterwith some versions oftifffile). So, my solution is the following:bioio-ome-tiff>=1.4.0, which handles the tifffile/OmeTiffWriter problem for usNote that the first bullet point of the solution should unblock endo from using
aicsfiles==8.1.0Before submitting
pytestcommand?pre-commit run -acommand?Did you have fun?
Make sure you had fun coding 🙃