-
Notifications
You must be signed in to change notification settings - Fork 0
Supplemental figure - linear regression model #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cfrick13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some bugs that need changing.
- adjust
exclude_outliers=Falseto beexclude_outliers=True - make
get_early_transient_gr_of_neighborhoodpulls features from the track itself by referencingdftinstead ofdf
nuc_morph_analysis/lib/preprocessing/global_dataset_filtering.py
Outdated
Show resolved
Hide resolved
nuc_morph_analysis/lib/preprocessing/global_dataset_filtering.py
Outdated
Show resolved
Hide resolved
|
Thank you @cfrick13 for your careful review! Please re-review now that I have made the changes you caught and recommended. I re-ran the workflow now that LRM 90 um radius neighborhood features have minimal filtering applied and ~early transient growth rate in 90 um radius is now track based on not whole colony. New figure outputs are attached. The maximum alpha reached for tolerance of 0.5 changed for each prediction feature but the actual results don't change that much. See below and I am happy to discuss!! coefficients_delta_volume_BC_alpha_10.2.pdf |
ritvikvasan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
nuc_morph_analysis/analyses/linear_regression/analysis_plots.py
Outdated
Show resolved
Hide resolved
nuc_morph_analysis/analyses/linear_regression/supplemental_lrm_figure_workflow.py
Outdated
Show resolved
Hide resolved
cfrick13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the major issue I have this time is rounding of r2 values (and others) that then later get averaged. I strongly encourage changing this even though the errors/artifacts it causes could be very small and not noticeable...but its just not a good practice to round values before taking a mean (or doing any stats).
Goal:
The goal of this PR was to add a new linear regression model to our analysis. This branch is a paired down version of the features_LRM (draft) with just the code used to generate the figure elements.
Features:
There are new features that have been added in the context of the LRM
Analysis:
Figures:
coefficients_delta_volume_BC_alpha_11.6.pdf
coefficients_duration_BC_alpha_0.8.pdf
delta_volume_BC_prediction_r_squared_matrix_alpha_0.pdf
duration_BC_prediction_r_squared_matrix_alpha_0.pdf
feature_correlation_clustermap.pdf