Skip to content

Conversation

@pgarrison
Copy link
Collaborator

@pgarrison pgarrison commented Nov 20, 2024

Context

The Make Requirements github action automatically updates the requirements.txt files and opens a PR to merge the changes. However, it only looks at the main branch, so it didn't run when the last dependency changes were made.

Changes

Track the bioRxiv-v1 and dev branches.

Testing

PR #41 was created by the updated action with the correct base branch (not main)

Other notes

This change should fix the github action for future changes to the dependencies. For the changes from 2 months ago (updating colorizer-data), I'm going to manually run the action.

Copy link
Collaborator

@jcass11 jcass11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@pgarrison
Copy link
Collaborator Author

Noticed another issue where main was referenced in other parts of the script.

@pgarrison pgarrison marked this pull request as draft November 20, 2024 19:05
@pgarrison
Copy link
Collaborator Author

Successfully tested now: PR #41 was created by the action with the correct base branch (not main)

@pgarrison pgarrison marked this pull request as ready for review November 20, 2024 19:08
@pgarrison pgarrison enabled auto-merge November 20, 2024 19:15
@pgarrison pgarrison added this pull request to the merge queue Nov 20, 2024
Merged via the queue into bioRxiv-v1 with commit 0df2599 Nov 20, 2024
5 checks passed
@pgarrison pgarrison deleted the make-requirements-branches branch November 20, 2024 19:21
@pgarrison pgarrison mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants