Add code to make formation/breakdown supp movie #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text, add timestamp function and add function for the movie specific df creation
cfrick13
approved these changes
Dec 6, 2024
| # the height is 5% of the axes height | ||
|
|
||
| ax.plot([x, x2], [y, y], color="w", linewidth=2) | ||
| ax.plot([x, x2], [y + 3, y + 3], color="w", linewidth=2) |
Contributor
There was a problem hiding this comment.
why was this change made? Won't it affect other panels in Figure1
Contributor
There was a problem hiding this comment.
Ok. I see now that this is just the scale bar location which is not critically important. I'll approve :)
Collaborator
Author
There was a problem hiding this comment.
Yes for me this was placing the scale bar with the micron symbol and the scalebar touching/overlapping and I wanted a physical space between them
chantelleleveille
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This code creates the new Supp Movie S6 which pairs with Figure 1F (shown below). It shows the sample nucleus cropped images from two frames before formation to two frames after breakdown, with segmentation outline shown for all interphase frames (just like 1F).
Output
Here's an example of a frame from this movie:
Notes about how the code was written
To make the movie I reused all the pieces I could from the Fig 1F code, including moving the AxesCreator class to
figure_helper.pyso it could be reused. There are some aspects of the new script to make the movie that are copies of pieces of the 1F workflow but I decided that at this point starting to actually pull the 1F workflow apart to make reusable functions for this was not worth it. Happy to revisit in the future.NOTE: This workflow takes hours to run. This PR was purposely does not add the movie making workflow to
figure_1_workflow.py- otherwise it would run every time we run/testrun_all_manuscript_workflows.pyand because this takes hours to run, that is too disruptive to be worth it.Testing
Aside from the new workflow it generates these code changes only impact figure 1 workflow code
figure_1_workflow.pystill runs and produces the old/expected output