Skip to content

Conversation

@chantelleleveille
Copy link
Collaborator

@chantelleleveille chantelleleveille commented Dec 7, 2024

Feature selection

Features used in development were pruned and the final set of updated features remain.

  • all calls to the old density column have been removed
  • features not used in analysis workflows have been dropped
  • features for TFE have been updated

Feature documentation

  • documentation tables have been updated
  • glossary definitions for TFE have been updated.

TFE outputs are being generated here: /allen/aics/assay-dev/users/Chantelle/colorizer/final/

chantelleleveille and others added 30 commits November 13, 2024 11:01
Quick run_all_manuscript_workflow error catching
@chantelleleveille chantelleleveille marked this pull request as ready for review December 7, 2024 01:32
@jcass11
Copy link
Collaborator

jcass11 commented Dec 7, 2024

Tests are fixed. Re-running run_all_manuscript_workflows.py for good measure.

@jcass11 jcass11 self-requested a review December 9, 2024 00:06
Copy link
Collaborator

@jcass11 jcass11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

====== Successes ======
figure_1_dataset (3050.4s) (56.2GB)
figure_3_s4_height_density (3218.3s) (50.0GB)
figure_4_s8_volume_trajectories (726.0s) (43.8GB)
figure_5_s9_s10_local_growth (2187.3s) (53.8GB)
figure_6_s11_compensation (730.5s) (43.9GB)
figure_7_s13_s14_lineage (899.5s) (43.8GB)
figure_s12_feeding_control (561.2s) (26.8GB)
figure_s15_linear_regression_model (1950.7s) (43.9GB)
figure_s19_transition_point (678.2s) (43.8GB)
figure_s1_cell_health (670.0s) (43.8GB)
figure_s20_precision_error (6.5s)
figure_s2_s3_s18_segmentation_model_validation (132.0s) (4.4GB)
figure_s6_s16_inhibitors (606.6s) (14.7GB)
figure_s7_growth_outliers (733.8s) (44.1GB)
====== 14 succeeded ======
YES!

Copy link
Contributor

@cfrick13 cfrick13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! So exciting to see this pushed to the finish line!

@chantelleleveille chantelleleveille added this pull request to the merge queue Dec 9, 2024
Merged via the queue into dev with commit 5cd9c51 Dec 9, 2024
1 check passed
@chantelleleveille chantelleleveille deleted the feature_documentation branch December 9, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants