Skip to content

Conversation

@jcass11
Copy link
Collaborator

@jcass11 jcass11 commented Dec 9, 2024

Note: this makes a minor edit to a figure/supp movie. It does not affect our features/manifest/data to upload to Quilt in any way.

Purpose

The main purpose of this PR is to update code to only show segmentations for frames through breakdown (the old version included an additional frame where the segmentation exists after breakdown but we agreed to change this). Old and new versions of Figure 1 which reflects this change are attached.
Figure1_after_removing_seg
Figure1_before_removing_seg
The resulting movie is attached.
https://github.com/user-attachments/assets/69dd53e4-6f71-47ad-ba13-ac26b36d1c55

I also fixed the local loading setup.

Testing

These changes only impact code used in movie_dataset_formation_breakdown.py and figure_dataset_formation_and_breakdown.py. I have run both of these and confirmed that the outputs are as expected.

@jcass11 jcass11 marked this pull request as ready for review December 9, 2024 18:13
@jcass11 jcass11 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into dev with commit 0d3b412 Dec 9, 2024
1 check passed
@jcass11 jcass11 deleted the formation_breakdown_movie branch December 9, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants