-
Notifications
You must be signed in to change notification settings - Fork 0
Remove aicsfiles from requirements.txt
#63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dmin/public-requirements`
…12-16_16-08 admin/requirements-update_2025-12-16_16-08
Sorry for my lack of knowledge here, but I'm not sure how things change for a user starting from scratch using Python 3.9 now that 3.9 has officially reached its end of life. If a user is following the instructions in the landing page readme we say to have python 3.9 downloaded first. In step 3 is there a change that we make to I am currently testing this branch as an external user (no VPN) on my Mac by following the current installation instructions on this branch with just the change of using @pgarrison wondering if you ran into any issues with this or if there is anything else I should change about how I follow the installation instructions? |
|
& following up on above Or do you want this PR to just isolate fixing the |
Yup, this one is just about removing AICS-specific dependencies from the requirements.txt files! |
jcass11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! When I tested with the basic installation it no longer fails looking aicsfiles ✅ there are downstream issues that are unrelated to this specific change but discussed with @pgarrison that that is not intended to be addressed in the PR. So this looks good to go for me!
aicsfiles from reuirements.txtaicsfiles from requirements.txt
Purpose
For non-AICS users, the
requirements.txtfiles shouldn't includeaicsfiles.Changes
-dflag to thepdm requirementscommand to ignoreaicsfilesin theinternaldependency grouppdmdocs that 2.12.2 is the version we test against, in case that helps someone debug.Testing
pdm run python run_all_manuscript_workflows.pywith virtual env fromrequirements.txt