Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom data accessor #418

Closed
wants to merge 4 commits into from
Closed

Conversation

jdeniau
Copy link

@jdeniau jdeniau commented Apr 26, 2016

I created a custom data accessor. The purpose is the same as #50 but it provide a more flexible way of doing it.

You only need to pass a dataAccess parameter to the TableHeaderColumn. The function takes the data as parameter and you can return whatever you want.

This way, it fixes nested properties, but also if you use something like immutablejs it works fine.

I kept the dataField attribute as I saw you use it for a lot of purpose, but as it is not used for accessing data, it's more like an id I think.

I make it work with simple filter, it does not work with search because you iterate over each object instead of each column here.

Fixes #50

@jdeniau
Copy link
Author

jdeniau commented Apr 26, 2016

The tests are failing on an npm error I think between react-toastr which now requires react >= 15 and your component and / or react-dom

@AllenFang
Copy link
Owner

@jdeniau, thanks your contribution :) I'll check this out in these day

jfremy added a commit to jfremy/react-bootstrap-table that referenced this pull request Jun 15, 2016
rebased the code on latest master
added support for search
updated example to show filtering and search
@welcoMattic
Copy link

Is someone still working on this PR? Fixing conflicts?

@jdeniau
Copy link
Author

jdeniau commented Sep 17, 2016

I'm not, I do not use this package anymore but feel free to update it

Le 16 sept. 2016 15:15, "Mathieu Santo Stefano--Féron" <
[email protected]> a écrit :

Is someone still working on this PR? Fixing conflicts?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#418 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVWxf1LGAdXOh1-cBHC5uIIdI964jbBks5qqpaGgaJpZM4IQNN_
.

@welcoMattic
Copy link

@AllenFang I think you can closes this PR since this one (#508) is open.

@jdeniau
Copy link
Author

jdeniau commented Jul 13, 2017

Closing in favor of #508

@jdeniau jdeniau closed this Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataField can't access subobject
3 participants