Skip to content

Alter neuropixel display script to use ccfwidgets #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rcpeene opened this issue Nov 21, 2022 · 14 comments
Closed

Alter neuropixel display script to use ccfwidgets #87

rcpeene opened this issue Nov 21, 2022 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@rcpeene
Copy link
Collaborator

rcpeene commented Nov 21, 2022

After the problems discussed in issue #42, we've resolved to try and replace the brainrender dependency with ccf widget. This will probably run faster and not crash on binder.

@rcpeene rcpeene self-assigned this Nov 21, 2022
@rcpeene rcpeene added the enhancement New feature or request label Nov 28, 2022
@rcpeene
Copy link
Collaborator Author

rcpeene commented Nov 28, 2022

I've made these changes and it functions well. There seems to be some broken functionality in ccf widgets with coloring the probe markers. I've made a ticket for for adding functionality #91.

@rcpeene
Copy link
Collaborator Author

rcpeene commented Dec 1, 2022

This works well except there it does not work on binder. When running the final cell to display the widget I get Error displaying widget: model not found. I believe this is the result of some mismatched dependencies. I will investigate more.

@rcpeene
Copy link
Collaborator Author

rcpeene commented Dec 6, 2022

I believe this to be an upstream problem with ipympl. I've commented on some existing issues there.

@jeromelecoq
Copy link
Collaborator

@rcpeene to write at the top of the notebook in BOLD if there are incompatibilities with binder

@jeromelecoq
Copy link
Collaborator

@rcpeene looking into whether there is a dependency issue. Some maintainers of the package provided some guidance. Will copy message here

@jeromelecoq
Copy link
Collaborator

@rcpeene will add text to point at running this outside of Binder and close

@rcpeene
Copy link
Collaborator Author

rcpeene commented Jan 5, 2023

Still working with ipympl on github to figure out a solution. In the meantime, I will add a disclaimer in the relevant notebooks saying it does not work on binder.

@rcpeene
Copy link
Collaborator Author

rcpeene commented Jan 6, 2023

Disclaimer has been added and pushed to branch neuropixel_probes. PR will be issued.

@jeromelecoq
Copy link
Collaborator

Once we finish NIH report, perhaps let's figure out an escape solution

@jeromelecoq
Copy link
Collaborator

@rcpeene will ping the team on the issue. If they address it in the days or so, we will incorporate their change otherwise, we should find an alternative way

@jeromelecoq
Copy link
Collaborator

A potential solution is to upgrade JupyterHub within binder deployed docker.

@rcpeene
Copy link
Collaborator Author

rcpeene commented Feb 1, 2023

Filed an issue with ipympl: matplotlib/ipympl#511

@rcpeene
Copy link
Collaborator Author

rcpeene commented Feb 1, 2023

While this is still probably good to solve, issue #148 serves as a workaround. For binder, but not dandihub. Talking to Satra about getting to work on dandihub.

@rcpeene
Copy link
Collaborator Author

rcpeene commented Feb 10, 2023

Closing this. Will make a new ticket if ccf-widgets ever makes bugfix

@rcpeene rcpeene closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants