[WIP] Unified Binary Reader/Writer #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This file in particular: src/db/datastore/tuple/binary/BinaryTupleReaderWriter.java |
Alphasite
changed the title
tyleri
reviewed
Nov 3, 2017
| @@ -120,7 +123,7 @@ private Tuple getNextTuple() { | |||
| * @inheritDoc | |||
| */ | |||
| @Override | |||
| public void seek(long index) { | |||
| public void seek(int index) { | |||
There was a problem hiding this comment.
Just curious, why the change to int?
There was a problem hiding this comment.
originally the BB required inputs as longs, but now a ton of external APIs require ints, so I flipped to what was most common.
tyleri
approved these changes
Nov 3, 2017
|
Why do we need this exactly ? Is it required before we do bulk loading or is it just to simplify some code in external sort / SMJ ? |
|
It simplifies the index creation, since you can implement random read and random write into the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This need a really through review, since it changes a core part of the system. Please check it over.