스플래시 스크린을 추가하고 스타일 적용 #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soopeach
requested changes
Mar 12, 2025
Member
soopeach
left a comment
soopeach
left a comment
There was a problem hiding this comment.
feature/home 은
화면 단위의 모듈인데 스플레시 api를 implementation 및 theme 설정을 하는게 이상한 느낌이에요..! feature/home에 종속된 기능이 아니니까.
다른 곳으로 빼는게 좋지 않을까요?
Contributor
Author
|
@soopeach 쏘리 너무 늦게봤다. |
Member
좋은 것 같아요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤘 작업 내용
📋 변경된 내용
💻 동작 화면
📌 비고