chore: remove unused legacy code (lineage and query panel) #1608
Conversation
WalkthroughThis pull request updates several configuration files while removing legacy lineage features. The GitHub Actions workflow and test configurations have been reformatted and streamlined. The Changes
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🔇 Additional comments (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
saravmajestic
changed the title
|
Generated with ❤️ by ellipsis.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
webview_panels/package.json (1)
14-14: Parallel Build Script Updated
The updated"build"script on line 14 now leveragesconcurrentlyto run both renderer and main builds simultaneously, which should help improve build performance. Please verify that the command options (e.g. disabling the empty out directory for the renderer build) are intended and work as expected across environments..github/actions/common-build/action.yml (1)
16-20: Review of NPM CI Steps
There are two separatenpm cisteps: one for the project root and one scoped to./webview_panels. Since the PR objective includes removing legacy build steps (for example, the redundantnpm cifor the legacynew_lineage_panel), please double-check that both of these steps are still necessary. Consolidating or clarifying their purpose might be beneficial for build performance and clarity..github/workflows/tests.yml (2)
17-24: Outdated Actions Versions – Checkout and Setup-Node
Static analysis recommends updating the versions of actions used here. For example, updatingactions/checkout@v3andactions/setup-node@v3to more recent versions (e.g.actions/[email protected]andactions/setup-node@v4) may address potential issues and leverage improvements by GitHub.The following diff is a suggestion for the
setup-nodeupdate:- - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4Consider a similar update for
actions/checkout.🧰 Tools
🪛 actionlint (1.7.4)
17-17: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
20-20: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
64-66: Outdated Codecov Action Version
The static analysis also flags thecodecov/codecov-action@v3as outdated. Updating to a newer major version (such as@v4if available) could resolve potential compatibility or performance issues.A possible diff might be:
- uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@v4🧰 Tools
🪛 actionlint (1.7.4)
65-65: the runner of "codecov/codecov-action@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (76)
new_lineage_panel/package-lock.jsonis excluded by!**/package-lock.jsonnew_lineage_panel/src/assets/icons/alert-circle.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/alert-error.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/analysis.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/arrow-left-double.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/arrow-left.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/arrow-right-double.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/arrow-right.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/boolean.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/chevron-down.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/chevron-up.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/code.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/datetime.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_cte_dark.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_cte_light.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_exposure_dark.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_exposure_light.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_metrics_dark.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_metrics_light.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_model_dark.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_model_light.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_seed_dark.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_seed_light.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_snapshot_dark.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_snapshot_light.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_source_dark.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/dbt_node_source_light.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/edit.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/ephemeral.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/expand-lineage.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/expand.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/exposure.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/external-project.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/feedback.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/gear.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/geospatial.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/help.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/macros.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/metrics.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/model.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/number.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/object.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/play-circle.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/preview.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/processing_screen.gifis excluded by!**/*.gifnew_lineage_panel/src/assets/icons/reset.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/robot1.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/rotate.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/seed.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/snapshot.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/source.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_filter.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_group_by.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_inner_join.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_left_join.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_limit.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_order_by.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_outer_join.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_right_join.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_select.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/sql_union.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/tests.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/text.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/thumbsdown-selected.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/thumbsdown.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/thumbsup-selected.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/thumbsup.svgis excluded by!**/*.svgnew_lineage_panel/src/assets/icons/x-close.svgis excluded by!**/*.svgquery_panel/assets/copy-regular.svgis excluded by!**/*.svgquery_panel/assets/perspective.cpp.wasmis excluded by!**/*.wasmquery_panel/assets/perspective_bg.wasmis excluded by!**/*.wasmquery_panel/assets/preview.svgis excluded by!**/*.svgquery_panel/assets/spinner.gifis excluded by!**/*.gifquery_panel/assets/tabulator.min.jsis excluded by!**/*.min.jsquery_panel/assets/toolkit.min.jsis excluded by!**/*.min.js
📒 Files selected for processing (65)
.github/actions/common-build/action.yml(1 hunks).github/workflows/tests.yml(2 hunks).vscodeignore(0 hunks)new_lineage_panel/.eslintrc.cjs(0 hunks)new_lineage_panel/.gitignore(0 hunks)new_lineage_panel/index.html(0 hunks)new_lineage_panel/package.json(0 hunks)new_lineage_panel/src/ActionWidget.tsx(0 hunks)new_lineage_panel/src/CustomNodes.tsx(0 hunks)new_lineage_panel/src/Demo.tsx(0 hunks)new_lineage_panel/src/ExposureDetails.tsx(0 hunks)new_lineage_panel/src/Feedback.tsx(0 hunks)new_lineage_panel/src/Help.tsx(0 hunks)new_lineage_panel/src/Lineage.tsx(0 hunks)new_lineage_panel/src/Modals.tsx(0 hunks)new_lineage_panel/src/MoreTables.tsx(0 hunks)new_lineage_panel/src/Settings.tsx(0 hunks)new_lineage_panel/src/StaticLineage.tsx(0 hunks)new_lineage_panel/src/TableDetails.tsx(0 hunks)new_lineage_panel/src/assets/animation/Loader.json(0 hunks)new_lineage_panel/src/components/Chip.tsx(0 hunks)new_lineage_panel/src/components/CodeBlock.tsx(0 hunks)new_lineage_panel/src/components/Column.tsx(0 hunks)new_lineage_panel/src/components/ColumnRow.tsx(0 hunks)new_lineage_panel/src/components/Form.tsx(0 hunks)new_lineage_panel/src/components/InfoIcon.tsx(0 hunks)new_lineage_panel/src/components/LineageLegend.tsx(0 hunks)new_lineage_panel/src/components/Loader/index.tsx(0 hunks)new_lineage_panel/src/components/Loader/styles.module.scss(0 hunks)new_lineage_panel/src/components/Modal/BetterPopover.tsx(0 hunks)new_lineage_panel/src/components/Modal/PageModal.css(0 hunks)new_lineage_panel/src/components/Modal/PageModal.tsx(0 hunks)new_lineage_panel/src/components/Modal/SidebarModal.css(0 hunks)new_lineage_panel/src/components/Modal/SidebarModal.tsx(0 hunks)new_lineage_panel/src/components/Modal/index.ts(0 hunks)new_lineage_panel/src/components/Modal/styles.module.scss(0 hunks)new_lineage_panel/src/components/Purpose.tsx(0 hunks)new_lineage_panel/src/components/Tags/index.tsx(0 hunks)new_lineage_panel/src/components/Tags/styles.module.scss(0 hunks)new_lineage_panel/src/components/Tooltip.tsx(0 hunks)new_lineage_panel/src/components/index.ts(0 hunks)new_lineage_panel/src/components/styles.module.scss(0 hunks)new_lineage_panel/src/constants.ts(0 hunks)new_lineage_panel/src/graph.ts(0 hunks)new_lineage_panel/src/index.css(0 hunks)new_lineage_panel/src/main.tsx(0 hunks)new_lineage_panel/src/service.ts(0 hunks)new_lineage_panel/src/service_utils.ts(0 hunks)new_lineage_panel/src/styles.module.scss(0 hunks)new_lineage_panel/src/utils.ts(0 hunks)new_lineage_panel/src/vite-env.d.ts(0 hunks)new_lineage_panel/tsconfig.json(0 hunks)new_lineage_panel/tsconfig.node.json(0 hunks)new_lineage_panel/vite.config.ts(0 hunks)package.json(2 hunks)query_panel/assets/perspective.js(0 hunks)query_panel/assets/prism-dark.css(0 hunks)query_panel/assets/prism-light.css(0 hunks)query_panel/assets/prism.js(0 hunks)query_panel/assets/tabulator.min.css(0 hunks)query_panel/index.html(0 hunks)query_panel/main.js(0 hunks)query_panel/style.css(0 hunks)tsconfig.json(1 hunks)webview_panels/package.json(1 hunks)
💤 Files with no reviewable changes (60)
- new_lineage_panel/src/components/Chip.tsx
- new_lineage_panel/src/components/Tooltip.tsx
- new_lineage_panel/src/components/Modal/index.ts
- new_lineage_panel/src/components/Modal/styles.module.scss
- new_lineage_panel/src/components/Modal/SidebarModal.css
- new_lineage_panel/src/vite-env.d.ts
- new_lineage_panel/src/components/Tags/index.tsx
- query_panel/assets/prism-light.css
- new_lineage_panel/.gitignore
- new_lineage_panel/src/components/Loader/index.tsx
- new_lineage_panel/src/Settings.tsx
- new_lineage_panel/tsconfig.node.json
- query_panel/assets/perspective.js
- new_lineage_panel/src/components/ColumnRow.tsx
- new_lineage_panel/src/Demo.tsx
- new_lineage_panel/package.json
- new_lineage_panel/src/components/Purpose.tsx
- new_lineage_panel/src/components/Loader/styles.module.scss
- new_lineage_panel/src/main.tsx
- new_lineage_panel/src/assets/animation/Loader.json
- .vscodeignore
- new_lineage_panel/vite.config.ts
- new_lineage_panel/src/components/LineageLegend.tsx
- query_panel/style.css
- query_panel/index.html
- new_lineage_panel/src/components/CodeBlock.tsx
- new_lineage_panel/src/components/Modal/PageModal.css
- query_panel/main.js
- new_lineage_panel/src/components/InfoIcon.tsx
- new_lineage_panel/src/components/Form.tsx
- new_lineage_panel/src/Feedback.tsx
- new_lineage_panel/src/Help.tsx
- new_lineage_panel/src/components/Modal/SidebarModal.tsx
- new_lineage_panel/src/Lineage.tsx
- new_lineage_panel/index.html
- query_panel/assets/prism-dark.css
- new_lineage_panel/.eslintrc.cjs
- new_lineage_panel/src/ExposureDetails.tsx
- new_lineage_panel/src/index.css
- new_lineage_panel/tsconfig.json
- new_lineage_panel/src/components/Tags/styles.module.scss
- new_lineage_panel/src/components/Modal/PageModal.tsx
- new_lineage_panel/src/StaticLineage.tsx
- new_lineage_panel/src/graph.ts
- new_lineage_panel/src/components/Column.tsx
- new_lineage_panel/src/components/index.ts
- new_lineage_panel/src/constants.ts
- new_lineage_panel/src/styles.module.scss
- query_panel/assets/tabulator.min.css
- new_lineage_panel/src/ActionWidget.tsx
- query_panel/assets/prism.js
- new_lineage_panel/src/MoreTables.tsx
- new_lineage_panel/src/Modals.tsx
- new_lineage_panel/src/CustomNodes.tsx
- new_lineage_panel/src/service_utils.ts
- new_lineage_panel/src/components/styles.module.scss
- new_lineage_panel/src/components/Modal/BetterPopover.tsx
- new_lineage_panel/src/service.ts
- new_lineage_panel/src/TableDetails.tsx
- new_lineage_panel/src/utils.ts
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/tests.yml
17-17: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
20-20: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
65-65: the runner of "codecov/codecov-action@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (5)
package.json (3)
1292-1295: Streamlined Prepublish Script
The updated"vscode:prepublish"script now omits the legacypanel:lineagecommand, aligning with the PR’s objectives of removing unused legacy code. This simplification should reduce build overhead and potential confusion.
1295-1297: Simplified Webpack Development Script
The"webpack-dev"script has been modified to remove legacy commands (such as references to lineage panels) and now focuses solely on building webviews, which meets the new streamlined build process.
1304-1306: Updated Panels Installation Command
The"install:panels"script now installs only thewebview_panels, ensuring that deprecated directories such asnew_lineage_panelare no longer included. This is in line with the removal of legacy code.tsconfig.json (1)
25-26: Updated Exclusion List in TypeScript Configuration
The removal of"new_lineage_panel"from the"exclude"array is correct given that legacy code is being removed. Just verify that including"webview_panels"in the exclusion list is intentional, as it might be compiled separately..github/actions/common-build/action.yml (1)
11-13: Cache Configuration Updated to Use Double Quotes
Changing thecacheparameter from single quotes to double quotes (line 12) improves consistency. The cache-dependency paths now correctly includepackage-lock.jsonandwebview_panels/package-lock.json.
Overview
Problem
new_lineage_panelandquery_panelwebviews are deprecated and code is not used anymore.current
webview_panelsbuild is slow because of 2 buildsSolution
Deleted directory
new_lineage_panel,query_paneland its referencesRun both builds in
webview_panelsin parallelScreenshot/Demo
A picture is worth a thousand words. Please highlight the changes if applicable.
How to test
Checklist
README.mdupdated and added information about my changeSummary by CodeRabbit
These improvements help maintain stability and performance by eliminating legacy code and ensuring a more efficient development workflow.