lock_object_storage_task_distribution_ms setting #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianton-ru
force-pushed
the
feature/cache_locality_lock
branch
from
fd2dde7 to
f1a4e00
Compare
ianton-ru
force-pushed
the
feature/cache_locality_lock
branch
from
f1a4e00 to
258bbbb
Compare
ianton-ru
commented
Jun 24, 2025
| """, | ||
| query_id=query_id_first, | ||
| timeout=30, |
There was a problem hiding this comment.
Timeouts removed, because it creates to many descriptors.
(https://github.com/Altinity/ClickHouse/blob/antalya/tests/integration/helpers/client.py#L209)
Locally tests failed with "too many open files".
ianton-ru
commented
Jun 24, 2025
| object_info = file_iterator->next(processor); | ||
|
|
||
| if (!object_info || object_info->getPath().empty()) | ||
| return {}; | ||
|
|
||
| StorageObjectStorageStableTaskDistributor::CommandInTaskResponse command(object_info->getPath()); | ||
| if (command.is_parsed()) |
There was a problem hiding this comment.
Not elegant, but for backward compatibility left string as filename and JSON as something with additional information.
Can be extended in future.
ianton-ru
commented
Jun 24, 2025
| : iterator(std::move(iterator_)) | ||
| , connection_to_files(ids_of_nodes_.size()) | ||
| , ids_of_nodes(ids_of_nodes_) | ||
| , lock_object_storage_task_distribution_us(lock_object_storage_task_distribution_ms_ * 1000) |
There was a problem hiding this comment.
Poco::Timestamp is in microseconds, so here convert from milliseconds to microseconds to avoid multiplications or divides later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Setting
lock_object_storage_task_distribution_msto improve cache locality with swarm clusterDocumentation entry for user-facing changes
Solve #867
Setting
lock_object_storage_task_distribution_msprevent object to be processed on non-primary swarm nodes when primary is alive at lastlock_object_storage_task_distribution_msmilliseconds.Swarm has 2 nodes, node1 processed all objects, node2 is overloaded and processed only part objects.
Behavior before PR and default (with
lock_object_storage_task_distribution_ms=0): node1 takes unprocessed objects.Behavior with
lock_object_storage_task_distribution_ms=3000- node1 takes unprocessed objects only if node2 does not take it for 3 seconds. If node2 took something 1 second ago, node1 waits and makes new request after 2 seconds. If node2 still did not take any object, objects goes to node1. It node2 took something, node1 waits again till the end of new 3-second period.Exclude tests: