Antalya 25.6.5: Expose IcebergS3 partition_key and sorting_key in system.tables #959
Conversation
zvonand
changed the title
zvonand
force-pushed
the
improvement/antalya/874
branch
2 times, most recently
from
099c984 to
f55dd06
Compare
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
| if (!schemas) | ||
| return map; | ||
|
|
||
| for (size_t i = 0; i < schemas->size(); ++i) |
There was a problem hiding this comment.
for (const auto & schema : *schemas)
{
if (!schema->has("schema-id"))
....
and the same way in other cycles over JSON::Array
There was a problem hiding this comment.
Does not look any better: in range-based loop, type will be wrong and will need to be converted explicitly later. This will not be better than it is already:
for (const auto & v : *schemas)
{
const auto & schema = v.extract<Poco::JSON::Object::Ptr>();| String result; | ||
| if (base == "identity") | ||
| result = col; | ||
| else if (base == "year" || base == "month" || base == "day" || base == "hour") |
There was a problem hiding this comment.
Am I right that these types can't have param?
If it true, than next block base != "void" make the same.
If it false, than we lost param, is it correct?
There was a problem hiding this comment.
Am I right that these types can't have
param?
Yes, correct
zvonand
force-pushed
the
improvement/antalya/874
branch
from
1d3f892 to
4980ec2
Compare
| IdToName buildIdToNameMap(const Poco::JSON::Object::Ptr & metadata_obj) | ||
| { | ||
| IdToName map; | ||
| if (!metadata_obj || !metadata_obj->has("current-schema-id") || !metadata_obj->has("schemas")) |
There was a problem hiding this comment.
Which docs/sample metadata object this implementation is based on?
Is it just https://iceberg.apache.org/spec/?h=schema+id#table-metadata-fields or is there anything else?
There was a problem hiding this comment.
Yes, based on docs and test
Closes #874.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Expose IcebergS3
partition_keyandsorting_keyinsystem.tablesExclude tests: