[이분탐색] 11월 8일 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chae-jpg
approved these changes
Nov 10, 2023
chae-jpg
left a comment
chae-jpg
left a comment
There was a problem hiding this comment.
[이분 탐색 코드 리뷰 완료]
10815(P3), 16401(P3)
안녕하세요 은솜님! 코드 리뷰 완료되었습니다👍
주석 처리도 좋고, 문제도 깔끔하게 너무 잘 풀어주셨어요!
도전 문제까지 모두 풀어주셨네요... 너무 멋집니다👍
몇 가지 사소한 코멘트 남겼습니다.
궁금하신 점이 있다면 리뷰어를 호출해주세요!
10_이분탐색/10815.cpp
Outdated
Comment on lines
+15
to
+22
10_이분탐색/10815.cpp
Outdated
There was a problem hiding this comment.
이분 탐색을 위해서는 자료가 정렬되어 있어야 한다는 성질을 잘 이용해주셨네요!👍
10_이분탐색/16401.cpp
Outdated
Comment on lines
+25
to
+36
10_이분탐색/16401.cpp
Outdated
Comment on lines
+13
to
+14
10_이분탐색/16401.cpp
Outdated
sawoll
reviewed
Nov 13, 2023
sawoll
left a comment
sawoll
left a comment
There was a problem hiding this comment.
[이분탐색 필수 구현문제 코드리뷰 완료]
(P3)14500
안녕하세요 예린님, 14500번 문제 리뷰 완료했습니다. 문제 조건에 집중하여 아주 잘 풀어주셨어요! 간단한 코멘트 남겨드렸으니 확인 부탁드립니다. 수고하셨습니다.😊
10_이분탐색/14500.java
Outdated
Comment on lines
+67
to
+69
There was a problem hiding this comment.
return 뒤에 있는 코드를 ()괄호로 묶어 주시면 더 좋을 것 같아요.😊
10_이분탐색/14500.java
Outdated
Comment on lines
+53
to
+58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###인적사항
학번 : 2271018
이름 : 김은솜
###과제제출
기존제출 : 10815, 14500, 16401, 2343, 3079
추가제출 :