12 트리 #9
Open
12 트리 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawoll
reviewed
Nov 27, 2023
sawoll
left a comment
sawoll
left a comment
There was a problem hiding this comment.
[12주차 트리 코드리뷰 완료]
안녕하세요 은솜님! 15681번 코드리뷰 완료되었습니다. 추가제출까지 확인되었습니다.
로직도 꼼꼼하게 잘 짜 주시고 주석도 잘 달아 주셔서 따로 코멘트 드릴 부분이 없었습니다. 수고 많으셨습니다.😊
mingulmangul
approved these changes
Nov 29, 2023
mingulmangul
left a comment
mingulmangul
left a comment
There was a problem hiding this comment.
[트리 구현 코드 리뷰 완료]
3190(P3)
안녕하세요 은솜님
구현할 것이 많은 문제였는데 정말 잘 풀어주신 것 같습니다 👍
코드도 깔끔하고 주석도 상세하게 달아주셔서 코멘트 남길 것이 정말 없었네요 ㅎㅎ 간단하게만 남겼으니 한 번 읽어봐주세요!
과제하느라 고생많으셨어요 🥰
12_트리/3190.cpp
Outdated
There was a problem hiding this comment.
P3. 주석에 표시해주셔서 이해는 쉽지만 그래도 0,1,2를 그대로 사용하는 것보다 상수로 정의해서 사용하면 더 좋을 것 같아요!
12_트리/3190.cpp
Outdated
There was a problem hiding this comment.
P3. 아주 사소한 것이지만 endl이 \n보다 느리다고 해요! 나중에 출력이 많은 문제를 풀 때 시간을 더 단축시키고 싶다면 이 점 기억해주시면 좋을 것 같아 코멘트 남깁니다 ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###인적사항
학번 : 2271018
이름 : 김은솜
###과제제출
기존제출 : 3190, 15681
추가제출 : 5639