Skip to content

fix: add macOS and Windows support to CI validation matrix#315

Merged
mvgadagi merged 16 commits into
AmadeusITGroup:mainfrom
mvgadagi:fix/mac-windows-arti-publish-for-prs
Jul 10, 2026
Merged

fix: add macOS and Windows support to CI validation matrix#315
mvgadagi merged 16 commits into
AmadeusITGroup:mainfrom
mvgadagi:fix/mac-windows-arti-publish-for-prs

Conversation

@mvgadagi

@mvgadagi mvgadagi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

  • The CI validation matrix in vscode-extension-secure-ci.yml was only running on ubuntu-latest, which meant VSIX artifacts were only built and published for Ubuntu. This PR expands the matrix to include macos-latest and windows-latest, ensuring VSIX packages are built and uploaded for all three major platforms.

  • Additionally, the CI workflow's path triggers did not include .github/workflows/**, so workflow-only changes (like this one) would not trigger CI runs. This has been fixed by adding .github/workflows/** to both the push and pull_request path filters.

  • A .gitattributes file has been added to enforce LF line endings on checkout, which prevents @stylistic/linebreak-style ESLint errors on Windows CI runners where git defaults to CRLF.
    https://github.com/AmadeusITGroup/ai-primitives-hub/actions/runs/28661383499/job/85002902309

  • And also Lazy load elasticsearch due to the following error (This appears to be only in Windows Platform)


orphan modules 442 KiB [orphan] 87 modules
runtime modules 793 bytes 4 modules
modules by path ./node_modules/ 4.41 MiB
  javascript modules 4.41 MiB 643 modules
  json modules 3.07 KiB
    ./node_modules/ajv/dist/refs/json-schema-draft-07.json 2.72 KiB [built] [code generated]
    ./node_modules/ajv/dist/refs/data.json 360 bytes [built] [code generated]
modules by path ./src/ 1.31 MiB 96 modules
+ 47 modules

WARNING in ./node_modules/@elastic/elasticsearch/lib/helpers.js 15:15-49
Module not found: Error: Can't resolve 'apache-arrow/Arrow.node' in 'D:\a\ai-primitives-hub\ai-primitives-hub\node_modules\@elastic\elasticsearch\lib'
 @ ./node_modules/@elastic/elasticsearch/lib/client.js 16:42-62
 @ ./node_modules/@elastic/elasticsearch/index.js 23:28-51
 @ ./src/services/elastic-search-transport.ts 38:24-57
 @ ./src/extension.ts 61:35-81

1 warning has detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🔧 Configuration/build changes

Related Issues

Closes #

Changes Made

  • Expanded the validate job matrix in .github/workflows/vscode-extension-secure-ci.yml from [ubuntu-latest] to [ubuntu-latest, macos-latest, windows-latest]
  • VSIX artifacts are now built and uploaded for all three platforms (Ubuntu, macOS, Windows)
  • Added .github/workflows/** to the push and pull_request path triggers so CI runs on workflow file changes
  • Added .gitattributes with * text=auto eol=lf to enforce LF line endings on checkout, fixing @stylistic/linebreak-style CRLF lint errors on Windows
  • Linux-specific steps (xvfb, apt-get) were already guarded with if: runner.os == 'Linux' conditions, so no additional changes were needed for cross-platform compatibility
  • The shell: bash directives use Git Bash on Windows, which provides the required Unix tools (unzip, ls, awk)

Testing

Test Coverage

  • All existing tests pass
  • Manual testing completed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • Any dependent changes have been merged and published

Documentation

  • No documentation changes needed

Additional Notes

The VSIX artifacts will now be named:

  • vsix-ubuntu-latest-node24
  • vsix-macos-latest-node24
  • vsix-windows-latest-node24

@mvgadagi mvgadagi force-pushed the fix/mac-windows-arti-publish-for-prs branch from b10be0b to e898315 Compare July 3, 2026 12:35
@mvgadagi mvgadagi marked this pull request as ready for review July 3, 2026 12:37
@mvgadagi mvgadagi marked this pull request as draft July 3, 2026 12:38
@mvgadagi mvgadagi force-pushed the fix/mac-windows-arti-publish-for-prs branch from e898315 to 460c077 Compare July 3, 2026 12:44
@mvgadagi mvgadagi force-pushed the fix/mac-windows-arti-publish-for-prs branch from 460c077 to 18336f2 Compare July 3, 2026 12:58
@mvgadagi mvgadagi marked this pull request as ready for review July 4, 2026 14:01
mvgadagi and others added 2 commits July 9, 2026 22:15
Remove the @prompts chat participant and its associated slash commands (/help, /list) from package.json and documentation. Move command registration in extension.ts to occur after migrations instead of before initialization. Delete extension-activation.test.ts and update package-configuration.test.ts to remove chat participant assertions. Add cross-platform path handling documentation for scaffold command.
@mvgadagi mvgadagi requested review from a team, gblanc-1a and wherka-ama July 10, 2026 18:41
xvfb-run -a npm test
xvfb-run -a npm run test:unit
else
npm test

@gblanc-1a gblanc-1a Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm test is actually running all tests including e2e tests are you sure you are not loosing that as part of the ci ? Are they still run somewhere else ?

=> Answered myself we are removing a duplicate run !

};

test('supports skill names that require YAML quoting', async () => {
const skillName = '-';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this case is really valid ? Do we have a real example of a use case like this one a bit more realist ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, that test is not needed, will clean that , thank you 👍

@gblanc-1a gblanc-1a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvgadagi mvgadagi merged commit f99b064 into AmadeusITGroup:main Jul 10, 2026
26 of 27 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Prompt Registry Jul 10, 2026
@mvgadagi mvgadagi deleted the fix/mac-windows-arti-publish-for-prs branch July 10, 2026 19:49

@wherka-ama wherka-ama left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants