Skip to content

Commit

Permalink
fix(renovate): add missing -- in npm run ng update command (#2847)
Browse files Browse the repository at this point in the history
## Proposed change

Fix an issue in renovate `otter-ng-update` preset when used with npm:
`--` was missing in the command, so `ng update` options such as
`--allow-dirty` were not taken into account.

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
  • Loading branch information
matthieu-crouzet authored Feb 14, 2025
2 parents e37c3b3 + 4ee8c70 commit 4120fd0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/renovate/tasks/otter-ng-update.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"postUpgradeTasks": {
"commands": [
"{{arg0}} install",
"{{arg0}} run ng update {{{depName}}} --from={{{currentVersion}}} --to={{{newVersion}}} --migrate-only --allow-dirty --force"
"{{arg0}} run ng update {{{depName}}} {{#if (equals '{{arg0}}' 'npm')}}-- {{/if}}--from={{{currentVersion}}} --to={{{newVersion}}} --migrate-only --allow-dirty --force"
],
"fileFilters": [
"!**/.{npmrc,yarnrc*}"
Expand Down

0 comments on commit 4120fd0

Please sign in to comment.