-
-
Notifications
You must be signed in to change notification settings - Fork 111
Register improve #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Register improve #295
Conversation
|
@Vidhi-Ajmera16355 This branch has conflicts that must be resolved |
|
client/src/pages/Registration.jsx This branch has conflicts that must be resolved |
| // Password Strength Indicator Component | ||
| const PasswordStrengthIndicator = ({ password }) => { | ||
| const requirements = [ | ||
| { test: (pwd) => pwd.length >= 8, label: "At least 8 characters" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be configurable. Create a config and provide the content from there
| return "Strong"; | ||
| }; | ||
|
|
||
| const getStrengthBarColor = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead if use switch here
| const handleLogout = () => { | ||
| localStorage.removeItem('token'); | ||
| localStorage.removeItem('userData'); | ||
| localStorage.removeItem("token"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automate these rules by using eslint
|
@Vidhi-Ajmera16355 This branch has conflicts that must be resolved |
📄 Description
This PR improves the Registration Page by enhancing form validation, improving UI consistency, and ensuring smoother user experience.
Key updates include:
These changes are necessary to make the registration process more user-friendly, prevent invalid submissions, and maintain design consistency across the app.
✅ Checklist
🔗 Related Issue
Closes #275
📸 Screenshots
🙏 Additional Notes