Feature / Keystore Extra Entropy #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sonytooo
commented
Feb 10, 2025
•
sonytooo
commented
- Resolves: https://github.com/AmbireTech/ambire-app/issues/1306
- adds extra entropy to the random seed phrase generation when creating a wallet from a new Seed Phrase
Ivshti
requested changes
Feb 11, 2025
| mainKey = { | ||
| key, | ||
| iv: randomBytes(16) |
There was a problem hiding this comment.
where do we take the extra entropy from?
There was a problem hiding this comment.
…h/ambire-common into feature/keystore-extra-entropy
superKalo
reviewed
Feb 18, 2025
superKalo
reviewed
Feb 18, 2025
superKalo
reviewed
Feb 18, 2025
superKalo
reviewed
Feb 18, 2025
superKalo
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.